diff options
| author | George L. Albany <Megacake1234@gmail.com> | 2024-11-21 12:32:07 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-11-21 12:32:07 +0000 |
| commit | a06b0a021c7ed07e3c1fa45392fa0ab49453c395 (patch) | |
| tree | 9720c2a80d962f6e7da32e121d40bf46d03b3699 | |
| parent | 9ba2401222d681f0ca7914991ce9295207c75b19 (diff) | |
| parent | e6c4359ef044b44de7d083cbde0dea2393f83e3a (diff) | |
| download | redot-engine-a06b0a021c7ed07e3c1fa45392fa0ab49453c395.tar.gz | |
Merge pull request #876 from Spartan322/revert/a0c1744
[4.3] Revert "ResourceLoader: Report error if resource type unrecognized"
| -rw-r--r-- | core/io/resource_loader.cpp | 21 |
1 files changed, 6 insertions, 15 deletions
diff --git a/core/io/resource_loader.cpp b/core/io/resource_loader.cpp index e8b4ad179c..04924129d7 100644 --- a/core/io/resource_loader.cpp +++ b/core/io/resource_loader.cpp @@ -286,13 +286,13 @@ Ref<Resource> ResourceLoader::_load(const String &p_path, const String &p_origin load_paths_stack.push_back(original_path); // Try all loaders and pick the first match for the type hint - bool loader_found = false; + bool found = false; Ref<Resource> res; for (int i = 0; i < loader_count; i++) { if (!loader[i]->recognize_path(p_path, p_type_hint)) { continue; } - loader_found = true; + found = true; res = loader[i]->load(p_path, original_path, r_error, p_use_sub_threads, r_progress, p_cache_mode); if (!res.is_null()) { break; @@ -307,24 +307,15 @@ Ref<Resource> ResourceLoader::_load(const String &p_path, const String &p_origin return res; } - if (!loader_found) { - if (r_error) { - *r_error = ERR_FILE_UNRECOGNIZED; - } - ERR_FAIL_V_MSG(Ref<Resource>(), vformat("No loader found for resource: %s (expected type: %s)", p_path, p_type_hint)); - } + ERR_FAIL_COND_V_MSG(found, Ref<Resource>(), + vformat("Failed loading resource: %s. Make sure resources have been imported by opening the project in the editor at least once.", p_path)); #ifdef TOOLS_ENABLED Ref<FileAccess> file_check = FileAccess::create(FileAccess::ACCESS_RESOURCES); - if (!file_check->file_exists(p_path)) { - if (r_error) { - *r_error = ERR_FILE_NOT_FOUND; - } - ERR_FAIL_V_MSG(Ref<Resource>(), vformat("Resource file not found: %s (expected type: %s)", p_path, p_type_hint)); - } + ERR_FAIL_COND_V_MSG(!file_check->file_exists(p_path), Ref<Resource>(), vformat("Resource file not found: %s (expected type: %s)", p_path, p_type_hint)); #endif - ERR_FAIL_V_MSG(Ref<Resource>(), vformat("Failed loading resource: %s. Make sure resources have been imported by opening the project in the editor at least once.", p_path)); + ERR_FAIL_V_MSG(Ref<Resource>(), vformat("No loader found for resource: %s (expected type: %s)", p_path, p_type_hint)); } // This implementation must allow re-entrancy for a task that started awaiting in a deeper stack frame. |