Fix heap-use-after-free when resource loaded with load_threaded_request is never fetched

Co-authored-by: Pedro J. Estébanez <pedrojrulez@gmail.com>

1 files changed, 3 insertions, 2 deletions

diff --git a/core/io/resource_loader.cpp b/core/io/resource_loader.cpp
index f7915261af..6721ec0953 100644
--- a/core/io/resource_loader.cpp
+++ b/core/io/resource_loader.cpp
@@ -1053,8 +1053,9 @@ void ResourceLoader::clear_thread_load_tasks() {
 		thread_load_mutex.lock();
 	}
 
-	for (KeyValue<String, LoadToken *> &E : user_load_tokens) {
-		memdelete(E.value);
+	while (user_load_tokens.begin()) {
+		// User load tokens remove themselves from the map on destruction.
+		memdelete(user_load_tokens.begin()->value);
 	}
 	user_load_tokens.clear();