diff options
| author | Thaer Razeq <RebelliousX@gmail.com> | 2017-02-23 02:28:09 -0600 |
|---|---|---|
| committer | REBELLIOUSX\Rebel_X <RebelliousX@gmail.com> | 2017-02-28 07:52:02 -0600 |
| commit | f50488a36188d5975bfa8554687a1acdd394d6a9 (patch) | |
| tree | 3b8712b9162aeb30e8eaaeeca63e6d04c7b9e3b5 /core/variant.cpp | |
| parent | 0f8c6dd3822c38b8145f08265abb9eba479f4d15 (diff) | |
| download | redot-engine-f50488a36188d5975bfa8554687a1acdd394d6a9.tar.gz | |
Various fixes detected using PVS-Studio static analyzer.
- Add FIXME tags comments to some unfixed potential bugs
- Remove some checks (always false: unsigned never < 0)
- Fix some if statements based on reviews.
- Bunch of missing `else` statements
Diffstat (limited to 'core/variant.cpp')
| -rw-r--r-- | core/variant.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/core/variant.cpp b/core/variant.cpp index 132d7a1c88..f45c3fd55d 100644 --- a/core/variant.cpp +++ b/core/variant.cpp @@ -2953,7 +2953,7 @@ uint32_t Variant::hash() const { PoolVector<p_type>::Read rr = r.read(); \ \ for(int i = 0; i < l.size(); ++i) { \ - if(! p_compare_func((lr[0]), (rr[0]))) \ + if(! p_compare_func((lr[i]), (rr[i]))) \ return false; \ }\ \ @@ -3065,7 +3065,7 @@ bool Variant::hash_compare(const Variant& p_variant) const { return false; for(int i = 0; i < l.size(); ++i) { - if(! l[0].hash_compare(r[0])) + if(! l[i].hash_compare(r[i])) return false; } |