summaryrefslogtreecommitdiffstats
path: root/editor/code_editor.cpp
diff options
context:
space:
mode:
authorjsjtxietian <jsjtxietian@outlook.com>2023-09-09 21:09:58 +0800
committerjsjtxietian <jsjtxietian@outlook.com>2023-09-20 18:55:48 +0800
commit12299e0f5310c2bf5df62a0284c9e2b151403b1e (patch)
tree8fa29fc5139a2e184ebcc92bde14a70ec50e72bd /editor/code_editor.cpp
parentfc99492d3066098e938449b10e02f8e01d07e2d1 (diff)
downloadredot-engine-12299e0f5310c2bf5df62a0284c9e2b151403b1e.tar.gz
Ignore empty lines when commenting/uncommenting code
Diffstat (limited to 'editor/code_editor.cpp')
-rw-r--r--editor/code_editor.cpp13
1 files changed, 11 insertions, 2 deletions
diff --git a/editor/code_editor.cpp b/editor/code_editor.cpp
index 876fef078b..7ad1c01c5a 100644
--- a/editor/code_editor.cpp
+++ b/editor/code_editor.cpp
@@ -1487,14 +1487,22 @@ void CodeTextEditor::toggle_inline_comment(const String &delimiter) {
}
// Check first if there's any uncommented lines in selection.
bool is_commented = true;
+ bool is_all_empty = true;
for (int line = from; line <= to; line++) {
// `+ delimiter.length()` here because comment delimiter is not actually `in comment` so we check first character after it
int delimiter_idx = text_editor->is_in_comment(line, text_editor->get_first_non_whitespace_column(line) + delimiter.length());
- if (delimiter_idx == -1 || text_editor->get_delimiter_start_key(delimiter_idx) != delimiter) {
+ // Empty lines should not be counted.
+ bool is_empty = text_editor->get_line(line).strip_edges().is_empty();
+ is_all_empty = is_all_empty && is_empty;
+ if (!is_empty && (delimiter_idx == -1 || text_editor->get_delimiter_start_key(delimiter_idx) != delimiter)) {
is_commented = false;
break;
}
}
+
+ // Special case for commenting empty lines, treat it/them as uncommented lines.
+ is_commented = is_commented && !is_all_empty;
+
// Caret positions need to be saved since they could be moved at the eol.
Vector<int> caret_cols;
Vector<int> selection_to_cols;
@@ -1510,10 +1518,11 @@ void CodeTextEditor::toggle_inline_comment(const String &delimiter) {
// Comment/uncomment.
for (int line = from; line <= to; line++) {
String line_text = text_editor->get_line(line);
- if (line_text.strip_edges().is_empty()) {
+ if (is_all_empty) {
text_editor->set_line(line, delimiter);
continue;
}
+
if (is_commented) {
text_editor->set_line(line, line_text.replace_first(delimiter, ""));
} else {