diff options
| author | David Snopek <dsnopek@gmail.com> | 2024-08-31 06:56:34 -0500 |
|---|---|---|
| committer | Rémi Verschelde <rverschelde@gmail.com> | 2024-09-17 08:57:42 +0200 |
| commit | 19843328d9cae74883cbac090c9573a86615ceb5 (patch) | |
| tree | e29bfc06f08d4f8086d411ebe6437618e5f2cf4c /platform | |
| parent | 1e9f5787400ab20ccde8fb043c9c80187edd6f07 (diff) | |
| download | redot-engine-19843328d9cae74883cbac090c9573a86615ceb5.tar.gz | |
GDExtension: Show warning on missing PDB file, rather than error
(cherry picked from commit 760099ca6fcebd92b6c6c9bd09ba3bbb643666be)
Diffstat (limited to 'platform')
| -rw-r--r-- | platform/windows/windows_utils.cpp | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/platform/windows/windows_utils.cpp b/platform/windows/windows_utils.cpp index 9e0b9eed8a..30743c6900 100644 --- a/platform/windows/windows_utils.cpp +++ b/platform/windows/windows_utils.cpp @@ -155,7 +155,11 @@ Error WindowsUtils::copy_and_rename_pdb(const String &p_dll_path) { } else if (!FileAccess::exists(copy_pdb_path)) { copy_pdb_path = dll_base_dir.path_join(copy_pdb_path.get_file()); } - ERR_FAIL_COND_V_MSG(!FileAccess::exists(copy_pdb_path), FAILED, vformat("File '%s' does not exist.", copy_pdb_path)); + if (!FileAccess::exists(copy_pdb_path)) { + // The PDB file may be distributed separately on purpose, so we don't consider this an error. + WARN_VERBOSE(vformat("PDB file '%s' for library '%s' was not found, skipping copy/rename.", copy_pdb_path, p_dll_path)); + return ERR_SKIP; + } String new_pdb_base_name = p_dll_path.get_file().get_basename() + "_"; |