Revert "Add missing SNAME macro optimization to all theme methods call"

This reverts commit a988fad9a092053434545c32afae91ccbdfbe792.

As discussed in #57725 and clarified in #57788, `SNAME` is not meant to be used
everywhere but only in critical code paths. For theme methods specifically, it
was by design that only getters use `SNAME` and not setters.

1 files changed, 24 insertions, 24 deletions

diff --git a/scene/gui/file_dialog.cpp b/scene/gui/file_dialog.cpp
index 83dc676c55..dad84461f4 100644
--- a/scene/gui/file_dialog.cpp
+++ b/scene/gui/file_dialog.cpp
@@ -65,30 +65,30 @@ void FileDialog::_theme_changed() {
 	Color font_focus_color = vbox->get_theme_color(SNAME("font_focus_color"), SNAME("Button"));
 	Color font_pressed_color = vbox->get_theme_color(SNAME("font_pressed_color"), SNAME("Button"));
 
-	dir_up->add_theme_color_override(SNAME("icon_normal_color"), font_color);
-	dir_up->add_theme_color_override(SNAME("icon_hover_color"), font_hover_color);
-	dir_up->add_theme_color_override(SNAME("icon_focus_color"), font_focus_color);
-	dir_up->add_theme_color_override(SNAME("icon_pressed_color"), font_pressed_color);
-
-	dir_prev->add_theme_color_override(SNAME("icon_color_normal"), font_color);
-	dir_prev->add_theme_color_override(SNAME("icon_color_hover"), font_hover_color);
-	dir_prev->add_theme_color_override(SNAME("icon_focus_color"), font_focus_color);
-	dir_prev->add_theme_color_override(SNAME("icon_color_pressed"), font_pressed_color);
-
-	dir_next->add_theme_color_override(SNAME("icon_color_normal"), font_color);
-	dir_next->add_theme_color_override(SNAME("icon_color_hover"), font_hover_color);
-	dir_next->add_theme_color_override(SNAME("icon_focus_color"), font_focus_color);
-	dir_next->add_theme_color_override(SNAME("icon_color_pressed"), font_pressed_color);
-
-	refresh->add_theme_color_override(SNAME("icon_normal_color"), font_color);
-	refresh->add_theme_color_override(SNAME("icon_hover_color"), font_hover_color);
-	refresh->add_theme_color_override(SNAME("icon_focus_color"), font_focus_color);
-	refresh->add_theme_color_override(SNAME("icon_pressed_color"), font_pressed_color);
-
-	show_hidden->add_theme_color_override(SNAME("icon_normal_color"), font_color);
-	show_hidden->add_theme_color_override(SNAME("icon_hover_color"), font_hover_color);
-	show_hidden->add_theme_color_override(SNAME("icon_focus_color"), font_focus_color);
-	show_hidden->add_theme_color_override(SNAME("icon_pressed_color"), font_pressed_color);
+	dir_up->add_theme_color_override("icon_normal_color", font_color);
+	dir_up->add_theme_color_override("icon_hover_color", font_hover_color);
+	dir_up->add_theme_color_override("icon_focus_color", font_focus_color);
+	dir_up->add_theme_color_override("icon_pressed_color", font_pressed_color);
+
+	dir_prev->add_theme_color_override("icon_color_normal", font_color);
+	dir_prev->add_theme_color_override("icon_color_hover", font_hover_color);
+	dir_prev->add_theme_color_override("icon_focus_color", font_focus_color);
+	dir_prev->add_theme_color_override("icon_color_pressed", font_pressed_color);
+
+	dir_next->add_theme_color_override("icon_color_normal", font_color);
+	dir_next->add_theme_color_override("icon_color_hover", font_hover_color);
+	dir_next->add_theme_color_override("icon_focus_color", font_focus_color);
+	dir_next->add_theme_color_override("icon_color_pressed", font_pressed_color);
+
+	refresh->add_theme_color_override("icon_normal_color", font_color);
+	refresh->add_theme_color_override("icon_hover_color", font_hover_color);
+	refresh->add_theme_color_override("icon_focus_color", font_focus_color);
+	refresh->add_theme_color_override("icon_pressed_color", font_pressed_color);
+
+	show_hidden->add_theme_color_override("icon_normal_color", font_color);
+	show_hidden->add_theme_color_override("icon_hover_color", font_hover_color);
+	show_hidden->add_theme_color_override("icon_focus_color", font_focus_color);
+	show_hidden->add_theme_color_override("icon_pressed_color", font_pressed_color);
 }
 
 void FileDialog::_notification(int p_what) {