Reduce unnecessary COW on Vector by make writing explicit

This commit makes operator[] on Vector const and adds a write proxy to it.  From
now on writes to Vectors need to happen through the .write proxy. So for
instance:

Vector<int> vec;
vec.push_back(10);
std::cout << vec[0] << std::endl;
vec.write[0] = 20;

Failing to use the .write proxy will cause a compilation error.

In addition COWable datatypes can now embed a CowData pointer to their data.
This means that String, CharString, and VMap no longer use or derive from
Vector.

_ALWAYS_INLINE_ and _FORCE_INLINE_ are now equivalent for debug and non-debug
builds. This is a lot faster for Vector in the editor and while running tests.
The reason why this difference used to exist is because force-inlined methods
used to give a bad debugging experience. After extensive testing with modern
compilers this is no longer the case.

1 files changed, 2 insertions, 2 deletions

diff --git a/servers/audio/effects/audio_effect_chorus.cpp b/servers/audio/effects/audio_effect_chorus.cpp
index f2f554a09b..fd9e3311e7 100644
--- a/servers/audio/effects/audio_effect_chorus.cpp
+++ b/servers/audio/effects/audio_effect_chorus.cpp
@@ -53,7 +53,7 @@ void AudioEffectChorusInstance::_process_chunk(const AudioFrame *p_src_frames, A
 
 	//fill ringbuffer
 	for (int i = 0; i < p_frame_count; i++) {
-		audio_buffer[(buffer_pos + i) & buffer_mask] = p_src_frames[i];
+		audio_buffer.write[(buffer_pos + i) & buffer_mask] = p_src_frames[i];
 		p_dst_frames[i] = p_src_frames[i] * base->dry;
 	}
 
@@ -175,7 +175,7 @@ Ref<AudioEffectInstance> AudioEffectChorus::instance() {
 	ins->buffer_pos = 0;
 	ins->audio_buffer.resize(ringbuff_size);
 	for (int i = 0; i < ringbuff_size; i++) {
-		ins->audio_buffer[i] = AudioFrame(0, 0);
+		ins->audio_buffer.write[i] = AudioFrame(0, 0);
 	}
 
 	return ins;