diff options
author | Rémi Verschelde <rverschelde@gmail.com> | 2020-05-14 14:29:06 +0200 |
---|---|---|
committer | Rémi Verschelde <rverschelde@gmail.com> | 2020-05-14 16:54:55 +0200 |
commit | 07bc4e2f96f8f47991339654ff4ab16acc19d44f (patch) | |
tree | 43cdc7cfe8239c23065616a931de3769d2db1e86 /servers/audio/effects/audio_effect_delay.cpp | |
parent | 0be6d925dc3c6413bce7a3ccb49631b8e4a6e67a (diff) | |
download | redot-engine-07bc4e2f96f8f47991339654ff4ab16acc19d44f.tar.gz |
Style: Enforce separation line between function definitions
I couldn't find a tool that enforces it, so I went the manual route:
```
find -name "thirdparty" -prune \
-o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \
-o -name "*.glsl" > files
perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files)
misc/scripts/fix_style.sh -c
```
This adds a newline after all `}` on the first column, unless they
are followed by `#` (typically `#endif`). This leads to having lots
of places with two lines between function/class definitions, but
clang-format then fixes it as we enforce max one line of separation.
This doesn't fix potential occurrences of function definitions which
are indented (e.g. for a helper class defined in a .cpp), but it's
better than nothing. Also can't be made to run easily on CI/hooks so
we'll have to be careful with new code.
Part of #33027.
Diffstat (limited to 'servers/audio/effects/audio_effect_delay.cpp')
-rw-r--r-- | servers/audio/effects/audio_effect_delay.cpp | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/servers/audio/effects/audio_effect_delay.cpp b/servers/audio/effects/audio_effect_delay.cpp index 2a613ad4f1..00cf7a0e70 100644 --- a/servers/audio/effects/audio_effect_delay.cpp +++ b/servers/audio/effects/audio_effect_delay.cpp @@ -153,6 +153,7 @@ float AudioEffectDelay::get_dry() { void AudioEffectDelay::set_tap1_active(bool p_active) { tap_1_active = p_active; } + bool AudioEffectDelay::is_tap1_active() const { return tap_1_active; } @@ -160,6 +161,7 @@ bool AudioEffectDelay::is_tap1_active() const { void AudioEffectDelay::set_tap1_delay_ms(float p_delay_ms) { tap_1_delay_ms = p_delay_ms; } + float AudioEffectDelay::get_tap1_delay_ms() const { return tap_1_delay_ms; } @@ -167,6 +169,7 @@ float AudioEffectDelay::get_tap1_delay_ms() const { void AudioEffectDelay::set_tap1_level_db(float p_level_db) { tap_1_level = p_level_db; } + float AudioEffectDelay::get_tap1_level_db() const { return tap_1_level; } @@ -174,6 +177,7 @@ float AudioEffectDelay::get_tap1_level_db() const { void AudioEffectDelay::set_tap1_pan(float p_pan) { tap_1_pan = p_pan; } + float AudioEffectDelay::get_tap1_pan() const { return tap_1_pan; } @@ -181,6 +185,7 @@ float AudioEffectDelay::get_tap1_pan() const { void AudioEffectDelay::set_tap2_active(bool p_active) { tap_2_active = p_active; } + bool AudioEffectDelay::is_tap2_active() const { return tap_2_active; } @@ -188,6 +193,7 @@ bool AudioEffectDelay::is_tap2_active() const { void AudioEffectDelay::set_tap2_delay_ms(float p_delay_ms) { tap_2_delay_ms = p_delay_ms; } + float AudioEffectDelay::get_tap2_delay_ms() const { return tap_2_delay_ms; } @@ -195,6 +201,7 @@ float AudioEffectDelay::get_tap2_delay_ms() const { void AudioEffectDelay::set_tap2_level_db(float p_level_db) { tap_2_level = p_level_db; } + float AudioEffectDelay::get_tap2_level_db() const { return tap_2_level; } @@ -202,6 +209,7 @@ float AudioEffectDelay::get_tap2_level_db() const { void AudioEffectDelay::set_tap2_pan(float p_pan) { tap_2_pan = p_pan; } + float AudioEffectDelay::get_tap2_pan() const { return tap_2_pan; } @@ -209,6 +217,7 @@ float AudioEffectDelay::get_tap2_pan() const { void AudioEffectDelay::set_feedback_active(bool p_active) { feedback_active = p_active; } + bool AudioEffectDelay::is_feedback_active() const { return feedback_active; } @@ -216,6 +225,7 @@ bool AudioEffectDelay::is_feedback_active() const { void AudioEffectDelay::set_feedback_delay_ms(float p_delay_ms) { feedback_delay_ms = p_delay_ms; } + float AudioEffectDelay::get_feedback_delay_ms() const { return feedback_delay_ms; } @@ -223,6 +233,7 @@ float AudioEffectDelay::get_feedback_delay_ms() const { void AudioEffectDelay::set_feedback_level_db(float p_level_db) { feedback_level = p_level_db; } + float AudioEffectDelay::get_feedback_level_db() const { return feedback_level; } @@ -230,6 +241,7 @@ float AudioEffectDelay::get_feedback_level_db() const { void AudioEffectDelay::set_feedback_lowpass(float p_lowpass) { feedback_lowpass = p_lowpass; } + float AudioEffectDelay::get_feedback_lowpass() const { return feedback_lowpass; } |