diff options
author | Rémi Verschelde <rverschelde@gmail.com> | 2020-05-14 14:29:06 +0200 |
---|---|---|
committer | Rémi Verschelde <rverschelde@gmail.com> | 2020-05-14 16:54:55 +0200 |
commit | 07bc4e2f96f8f47991339654ff4ab16acc19d44f (patch) | |
tree | 43cdc7cfe8239c23065616a931de3769d2db1e86 /servers/audio/effects/audio_effect_phaser.cpp | |
parent | 0be6d925dc3c6413bce7a3ccb49631b8e4a6e67a (diff) | |
download | redot-engine-07bc4e2f96f8f47991339654ff4ab16acc19d44f.tar.gz |
Style: Enforce separation line between function definitions
I couldn't find a tool that enforces it, so I went the manual route:
```
find -name "thirdparty" -prune \
-o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \
-o -name "*.glsl" > files
perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files)
misc/scripts/fix_style.sh -c
```
This adds a newline after all `}` on the first column, unless they
are followed by `#` (typically `#endif`). This leads to having lots
of places with two lines between function/class definitions, but
clang-format then fixes it as we enforce max one line of separation.
This doesn't fix potential occurrences of function definitions which
are indented (e.g. for a helper class defined in a .cpp), but it's
better than nothing. Also can't be made to run easily on CI/hooks so
we'll have to be careful with new code.
Part of #33027.
Diffstat (limited to 'servers/audio/effects/audio_effect_phaser.cpp')
-rw-r--r-- | servers/audio/effects/audio_effect_phaser.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/servers/audio/effects/audio_effect_phaser.cpp b/servers/audio/effects/audio_effect_phaser.cpp index 0d3d2f74a5..ffeaa7d25e 100644 --- a/servers/audio/effects/audio_effect_phaser.cpp +++ b/servers/audio/effects/audio_effect_phaser.cpp @@ -99,6 +99,7 @@ float AudioEffectPhaser::get_range_min_hz() const { void AudioEffectPhaser::set_range_max_hz(float p_hz) { range_max = p_hz; } + float AudioEffectPhaser::get_range_max_hz() const { return range_max; } @@ -106,6 +107,7 @@ float AudioEffectPhaser::get_range_max_hz() const { void AudioEffectPhaser::set_rate_hz(float p_hz) { rate = p_hz; } + float AudioEffectPhaser::get_rate_hz() const { return rate; } @@ -113,6 +115,7 @@ float AudioEffectPhaser::get_rate_hz() const { void AudioEffectPhaser::set_feedback(float p_fbk) { feedback = p_fbk; } + float AudioEffectPhaser::get_feedback() const { return feedback; } |