diff options
author | Arseny Kapoulkine <arseny.kapoulkine@gmail.com> | 2024-08-16 22:08:21 -0700 |
---|---|---|
committer | Arseny Kapoulkine <arseny.kapoulkine@gmail.com> | 2024-08-16 22:44:57 -0700 |
commit | 0024cface56be436f6e5cd12d090333e8a6b3ef0 (patch) | |
tree | 2cd59dcd52354d3365ffe788f5d3ad2dadb7bfba /thirdparty/basis_universal/transcoder/basisu_transcoder.cpp | |
parent | 5b6d9a7dd815a3dbd005626710ceb22e4e42ea3e (diff) | |
download | redot-engine-0024cface56be436f6e5cd12d090333e8a6b3ef0.tar.gz |
Fix double free in FSR2 destructor
Before this change, using FSR2 resulted in the following error when the
effect was destroyed:
ERROR: Attempted to free invalid ID: 662734928609453
at: _free_internal (servers/rendering/rendering_device.cpp:4957)
This happened because ACCUMULATE and ACCUMULATE_SHARPEN passes shared
the same shader_version object but had different pipeline IDs. When
version_free was called for ACCUMULATE pass, it destroyed pipelines
created from that version, including the pipeline for the
ACCUMULATE_SHARPEN pass.
Using a unique version could work around this problem, but it's easier
to rely on version_free destroying the created pipelines through the
dependency mechanism.
Diffstat (limited to 'thirdparty/basis_universal/transcoder/basisu_transcoder.cpp')
0 files changed, 0 insertions, 0 deletions