diff options
Diffstat (limited to 'core/math')
| -rw-r--r-- | core/math/basis.cpp | 7 | ||||
| -rw-r--r-- | core/math/basis.h | 2 | ||||
| -rw-r--r-- | core/math/color.cpp | 12 | ||||
| -rw-r--r-- | core/math/transform_3d.cpp | 8 | ||||
| -rw-r--r-- | core/math/transform_3d.h | 4 |
5 files changed, 16 insertions, 17 deletions
diff --git a/core/math/basis.cpp b/core/math/basis.cpp index bfd902c7e2..1481dbc32e 100644 --- a/core/math/basis.cpp +++ b/core/math/basis.cpp @@ -1016,12 +1016,15 @@ void Basis::rotate_sh(real_t *p_values) { p_values[8] = d4 * s_scale_dst4; } -Basis Basis::looking_at(const Vector3 &p_target, const Vector3 &p_up) { +Basis Basis::looking_at(const Vector3 &p_target, const Vector3 &p_up, bool p_use_model_front) { #ifdef MATH_CHECKS ERR_FAIL_COND_V_MSG(p_target.is_zero_approx(), Basis(), "The target vector can't be zero."); ERR_FAIL_COND_V_MSG(p_up.is_zero_approx(), Basis(), "The up vector can't be zero."); #endif - Vector3 v_z = -p_target.normalized(); + Vector3 v_z = p_target.normalized(); + if (!p_use_model_front) { + v_z = -v_z; + } Vector3 v_x = p_up.cross(v_z); #ifdef MATH_CHECKS ERR_FAIL_COND_V_MSG(v_x.is_zero_approx(), Basis(), "The target vector and up vector can't be parallel to each other."); diff --git a/core/math/basis.h b/core/math/basis.h index bbc1d40469..1a68bee686 100644 --- a/core/math/basis.h +++ b/core/math/basis.h @@ -217,7 +217,7 @@ struct _NO_DISCARD_ Basis { operator Quaternion() const { return get_quaternion(); } - static Basis looking_at(const Vector3 &p_target, const Vector3 &p_up = Vector3(0, 1, 0)); + static Basis looking_at(const Vector3 &p_target, const Vector3 &p_up = Vector3(0, 1, 0), bool p_use_model_front = false); Basis(const Quaternion &p_quaternion) { set_quaternion(p_quaternion); }; Basis(const Quaternion &p_quaternion, const Vector3 &p_scale) { set_quaternion_scale(p_quaternion, p_scale); } diff --git a/core/math/color.cpp b/core/math/color.cpp index 0d9325f236..d36306d968 100644 --- a/core/math/color.cpp +++ b/core/math/color.cpp @@ -247,8 +247,7 @@ void Color::set_ok_hsl(float p_h, float p_s, float p_l, float p_alpha) { hsl.h = p_h; hsl.s = p_s; hsl.l = p_l; - ok_color new_ok_color; - ok_color::RGB rgb = new_ok_color.okhsl_to_srgb(hsl); + ok_color::RGB rgb = ok_color::okhsl_to_srgb(hsl); Color c = Color(rgb.r, rgb.g, rgb.b, p_alpha).clamp(); r = c.r; g = c.g; @@ -595,8 +594,7 @@ float Color::get_ok_hsl_h() const { rgb.r = r; rgb.g = g; rgb.b = b; - ok_color new_ok_color; - ok_color::HSL ok_hsl = new_ok_color.srgb_to_okhsl(rgb); + ok_color::HSL ok_hsl = ok_color::srgb_to_okhsl(rgb); if (Math::is_nan(ok_hsl.h)) { return 0.0f; } @@ -608,8 +606,7 @@ float Color::get_ok_hsl_s() const { rgb.r = r; rgb.g = g; rgb.b = b; - ok_color new_ok_color; - ok_color::HSL ok_hsl = new_ok_color.srgb_to_okhsl(rgb); + ok_color::HSL ok_hsl = ok_color::srgb_to_okhsl(rgb); if (Math::is_nan(ok_hsl.s)) { return 0.0f; } @@ -621,8 +618,7 @@ float Color::get_ok_hsl_l() const { rgb.r = r; rgb.g = g; rgb.b = b; - ok_color new_ok_color; - ok_color::HSL ok_hsl = new_ok_color.srgb_to_okhsl(rgb); + ok_color::HSL ok_hsl = ok_color::srgb_to_okhsl(rgb); if (Math::is_nan(ok_hsl.l)) { return 0.0f; } diff --git a/core/math/transform_3d.cpp b/core/math/transform_3d.cpp index 8d497209f1..cdc94676c9 100644 --- a/core/math/transform_3d.cpp +++ b/core/math/transform_3d.cpp @@ -77,20 +77,20 @@ void Transform3D::rotate_basis(const Vector3 &p_axis, real_t p_angle) { basis.rotate(p_axis, p_angle); } -Transform3D Transform3D::looking_at(const Vector3 &p_target, const Vector3 &p_up) const { +Transform3D Transform3D::looking_at(const Vector3 &p_target, const Vector3 &p_up, bool p_use_model_front) const { #ifdef MATH_CHECKS ERR_FAIL_COND_V_MSG(origin.is_equal_approx(p_target), Transform3D(), "The transform's origin and target can't be equal."); #endif Transform3D t = *this; - t.basis = Basis::looking_at(p_target - origin, p_up); + t.basis = Basis::looking_at(p_target - origin, p_up, p_use_model_front); return t; } -void Transform3D::set_look_at(const Vector3 &p_eye, const Vector3 &p_target, const Vector3 &p_up) { +void Transform3D::set_look_at(const Vector3 &p_eye, const Vector3 &p_target, const Vector3 &p_up, bool p_use_model_front) { #ifdef MATH_CHECKS ERR_FAIL_COND_MSG(p_eye.is_equal_approx(p_target), "The eye and target vectors can't be equal."); #endif - basis = Basis::looking_at(p_target - p_eye, p_up); + basis = Basis::looking_at(p_target - p_eye, p_up, p_use_model_front); origin = p_eye; } diff --git a/core/math/transform_3d.h b/core/math/transform_3d.h index bf1b4cdb63..70141a3dbe 100644 --- a/core/math/transform_3d.h +++ b/core/math/transform_3d.h @@ -52,8 +52,8 @@ struct _NO_DISCARD_ Transform3D { void rotate(const Vector3 &p_axis, real_t p_angle); void rotate_basis(const Vector3 &p_axis, real_t p_angle); - void set_look_at(const Vector3 &p_eye, const Vector3 &p_target, const Vector3 &p_up = Vector3(0, 1, 0)); - Transform3D looking_at(const Vector3 &p_target, const Vector3 &p_up = Vector3(0, 1, 0)) const; + void set_look_at(const Vector3 &p_eye, const Vector3 &p_target, const Vector3 &p_up = Vector3(0, 1, 0), bool p_use_model_front = false); + Transform3D looking_at(const Vector3 &p_target, const Vector3 &p_up = Vector3(0, 1, 0), bool p_use_model_front = false) const; void scale(const Vector3 &p_scale); Transform3D scaled(const Vector3 &p_scale) const; |