From ec29c3e784abdf891abd38f42444216e3d2a0fb7 Mon Sep 17 00:00:00 2001
From: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Date: Mon, 18 Mar 2024 15:10:37 +0100
Subject: [Core] Fix property access on read-only `Dictionary`

---
 core/variant/variant_setget.cpp | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

(limited to 'core/variant/variant_setget.cpp')

diff --git a/core/variant/variant_setget.cpp b/core/variant/variant_setget.cpp
index 9d5ed22b1a..f49e9e54b3 100644
--- a/core/variant/variant_setget.cpp
+++ b/core/variant/variant_setget.cpp
@@ -251,15 +251,21 @@ void Variant::set_named(const StringName &p_member, const Variant &p_value, bool
 			return;
 		}
 	} else if (type == Variant::DICTIONARY) {
-		Variant *v = VariantGetInternalPtr<Dictionary>::get_ptr(this)->getptr(p_member);
+		Dictionary &dict = *VariantGetInternalPtr<Dictionary>::get_ptr(this);
+
+		if (dict.is_read_only()) {
+			r_valid = false;
+			return;
+		}
+
+		Variant *v = dict.getptr(p_member);
 		if (v) {
 			*v = p_value;
-			r_valid = true;
 		} else {
-			VariantGetInternalPtr<Dictionary>::get_ptr(this)->operator[](p_member) = p_value;
-			r_valid = true;
+			dict[p_member] = p_value;
 		}
 
+		r_valid = true;
 	} else {
 		r_valid = false;
 	}
-- 
cgit v1.2.3