From 0ef758eaeeb5b2f44e132865f0f10baf692e972f Mon Sep 17 00:00:00 2001
From: SkyJJ <jjchai01@hotmail.com>
Date: Fri, 7 Aug 2020 13:17:12 +0200
Subject: Updated Translation architecture to have TranslationPO, did some
 commit fixes and updated class Reference.

---
 editor/editor_translation_parser.cpp | 2 +-
 editor/scene_tree_editor.cpp         | 2 +-
 editor/translations/extract.py       | 4 +---
 3 files changed, 3 insertions(+), 5 deletions(-)

(limited to 'editor')

diff --git a/editor/editor_translation_parser.cpp b/editor/editor_translation_parser.cpp
index e664292796..7a90d20000 100644
--- a/editor/editor_translation_parser.cpp
+++ b/editor/editor_translation_parser.cpp
@@ -54,7 +54,7 @@ Error EditorTranslationParserPlugin::parse_file(const String &p_path, Vector<Str
 		// Add user's collected translatable messages with context or plurals.
 		for (int i = 0; i < ids_ctx_plural.size(); i++) {
 			Array arr = ids_ctx_plural[i];
-			ERR_FAIL_COND_V_MSG(arr.size() != 3, ERR_INVALID_DATA, "Array entries written into msgids_ctx_plural of EditorTranslationParserPlugin parse_file() method should have the form [\"message\",\"context\",\"plural message\"]");
+			ERR_FAIL_COND_V_MSG(arr.size() != 3, ERR_INVALID_DATA, "Array entries written into `msgids_context_plural` in `parse_file()` method should have the form [\"message\", \"context\", \"plural message\"]");
 
 			Vector<String> id_ctx_plural;
 			id_ctx_plural.push_back(arr[0]);
diff --git a/editor/scene_tree_editor.cpp b/editor/scene_tree_editor.cpp
index ca173653a8..a62448169d 100644
--- a/editor/scene_tree_editor.cpp
+++ b/editor/scene_tree_editor.cpp
@@ -271,7 +271,7 @@ bool SceneTreeEditor::_add_nodes(Node *p_node, TreeItem *p_parent) {
 			msg_temp += TTRN("Node is in one group.", "Node is in {num} groups.", num_groups).format(arr, "{num}");
 		}
 		if (num_connections >= 1 || num_groups >= 1) {
-			msg_temp += TTR("\nClick to show signals dock.");
+			msg_temp += "\n" + TTR("Click to show signals dock.");
 		}
 
 		Ref<Texture2D> icon_temp;
diff --git a/editor/translations/extract.py b/editor/translations/extract.py
index 42a078b3e3..5ca3d8c0ed 100755
--- a/editor/translations/extract.py
+++ b/editor/translations/extract.py
@@ -78,8 +78,6 @@ def _add_additional_location(msgctx, msg, location):
 
     if msg_pos == -1:
         print("Someone apparently thought writing Python was as easy as GDScript. Ping Akien.")
-    # NOTE FOR MENTORS: When I tested on my computer (windows) I need the extra \n#: to make the locations print line by line.
-    # but it worked before without \n# so I will leave it like before
     main_po = main_po[:msg_pos] + " " + location + main_po[msg_pos:]
 
 
@@ -171,7 +169,7 @@ print("Updating the editor.pot template...")
 for fname in matches:
     # NOTE FOR MENTORS: When I tested on windows I need to add encoding="utf8" at the end to be able to open the file.
     # maybe on Linux there's no need.
-    with open(fname, "r") as f:
+    with open(fname, "r", encoding="utf8") as f:
         process_file(f, fname)
 
 with open("editor.pot", "w") as f:
-- 
cgit v1.2.3