From 99b702ea3d12952b842055a4d5d4b1928ed69186 Mon Sep 17 00:00:00 2001 From: George Marques Date: Tue, 30 Apr 2024 11:50:10 -0300 Subject: GDScript: Call implicit ready on base script first It is generally expected that the base class is called before the inherited clas. This commit implements this behavior for the implicit ready function (`@onready` annotation) to make it consistent with the expectations. --- .../runtime/features/onready_base_before_subclass.gd | 18 ++++++++++++++++++ .../runtime/features/onready_base_before_subclass.out | 3 +++ 2 files changed, 21 insertions(+) create mode 100644 modules/gdscript/tests/scripts/runtime/features/onready_base_before_subclass.gd create mode 100644 modules/gdscript/tests/scripts/runtime/features/onready_base_before_subclass.out (limited to 'modules/gdscript/tests/scripts') diff --git a/modules/gdscript/tests/scripts/runtime/features/onready_base_before_subclass.gd b/modules/gdscript/tests/scripts/runtime/features/onready_base_before_subclass.gd new file mode 100644 index 0000000000..99156adb28 --- /dev/null +++ b/modules/gdscript/tests/scripts/runtime/features/onready_base_before_subclass.gd @@ -0,0 +1,18 @@ +#GH-63329 +class A extends Node: + @onready var a := get_value("a") + + func get_value(var_name: String) -> String: + print(var_name) + return var_name + +class B extends A: + @onready var b := get_value("b") + + func _ready(): + pass + +func test(): + var node := B.new() + node._ready() + node.free() diff --git a/modules/gdscript/tests/scripts/runtime/features/onready_base_before_subclass.out b/modules/gdscript/tests/scripts/runtime/features/onready_base_before_subclass.out new file mode 100644 index 0000000000..b417ce67ca --- /dev/null +++ b/modules/gdscript/tests/scripts/runtime/features/onready_base_before_subclass.out @@ -0,0 +1,3 @@ +GDTEST_OK +a +b -- cgit v1.2.3