From 07bc4e2f96f8f47991339654ff4ab16acc19d44f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Verschelde?= Date: Thu, 14 May 2020 14:29:06 +0200 Subject: Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027. --- scene/resources/navigation_mesh.cpp | 3 +++ 1 file changed, 3 insertions(+) (limited to 'scene/resources/navigation_mesh.cpp') diff --git a/scene/resources/navigation_mesh.cpp b/scene/resources/navigation_mesh.cpp index f5d3c7a3fb..13d818188d 100644 --- a/scene/resources/navigation_mesh.cpp +++ b/scene/resources/navigation_mesh.cpp @@ -279,13 +279,16 @@ void NavigationMesh::add_polygon(const Vector &p_polygon) { polygons.push_back(polygon); _change_notify(); } + int NavigationMesh::get_polygon_count() const { return polygons.size(); } + Vector NavigationMesh::get_polygon(int p_idx) { ERR_FAIL_INDEX_V(p_idx, polygons.size(), Vector()); return polygons[p_idx].indices; } + void NavigationMesh::clear_polygons() { polygons.clear(); } -- cgit v1.2.3