diff options
author | A Thousand Ships <96648715+AThousandShips@users.noreply.github.com> | 2023-09-12 15:33:49 +0200 |
---|---|---|
committer | A Thousand Ships <96648715+AThousandShips@users.noreply.github.com> | 2023-09-13 14:34:04 +0200 |
commit | 1e5767693e45f58e2ffdc45d4c4f26057e25a2d6 (patch) | |
tree | b65c1480f53655ef849d65b1051c89d4e0b769c0 /include/godot_cpp | |
parent | 6caf4909d42c04de25d9c34e89da7aa078fb485f (diff) | |
download | redot-cpp-1e5767693e45f58e2ffdc45d4c4f26057e25a2d6.tar.gz |
Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
Diffstat (limited to 'include/godot_cpp')
-rw-r--r-- | include/godot_cpp/classes/ref.hpp | 2 | ||||
-rw-r--r-- | include/godot_cpp/core/class_db.hpp | 2 | ||||
-rw-r--r-- | include/godot_cpp/core/memory.hpp | 2 | ||||
-rw-r--r-- | include/godot_cpp/templates/cowdata.hpp | 6 | ||||
-rw-r--r-- | include/godot_cpp/templates/list.hpp | 2 | ||||
-rw-r--r-- | include/godot_cpp/templates/rid_owner.hpp | 6 | ||||
-rw-r--r-- | include/godot_cpp/templates/thread_work_pool.hpp | 8 |
7 files changed, 14 insertions, 14 deletions
diff --git a/include/godot_cpp/classes/ref.hpp b/include/godot_cpp/classes/ref.hpp index f30928a..f3fc3e9 100644 --- a/include/godot_cpp/classes/ref.hpp +++ b/include/godot_cpp/classes/ref.hpp @@ -63,7 +63,7 @@ class Ref { } void ref_pointer(T *p_ref) { - ERR_FAIL_COND(!p_ref); + ERR_FAIL_NULL(p_ref); if (p_ref->init_ref()) { reference = p_ref; diff --git a/include/godot_cpp/core/class_db.hpp b/include/godot_cpp/core/class_db.hpp index 1a17b57..3f2b946 100644 --- a/include/godot_cpp/core/class_db.hpp +++ b/include/godot_cpp/core/class_db.hpp @@ -253,7 +253,7 @@ MethodBind *ClassDB::bind_static_method(StringName p_class, N p_method_name, M p template <class M> MethodBind *ClassDB::bind_vararg_method(uint32_t p_flags, StringName p_name, M p_method, const MethodInfo &p_info, const std::vector<Variant> &p_default_args, bool p_return_nil_is_variant) { MethodBind *bind = create_vararg_method_bind(p_method, p_info, p_return_nil_is_variant); - ERR_FAIL_COND_V(!bind, nullptr); + ERR_FAIL_NULL_V(bind, nullptr); bind->set_name(p_name); bind->set_default_arguments(p_default_args); diff --git a/include/godot_cpp/core/memory.hpp b/include/godot_cpp/core/memory.hpp index dd4a155..548f330 100644 --- a/include/godot_cpp/core/memory.hpp +++ b/include/godot_cpp/core/memory.hpp @@ -146,7 +146,7 @@ T *memnew_arr_template(size_t p_elements, const char *p_descr = "") { size_t len = sizeof(T) * p_elements; uint64_t *mem = (uint64_t *)Memory::alloc_static(len, true); T *failptr = nullptr; // Get rid of a warning. - ERR_FAIL_COND_V(!mem, failptr); + ERR_FAIL_NULL_V(mem, failptr); *(mem - 1) = p_elements; if (!std::is_trivially_destructible<T>::value) { diff --git a/include/godot_cpp/templates/cowdata.hpp b/include/godot_cpp/templates/cowdata.hpp index d3ea982..121351b 100644 --- a/include/godot_cpp/templates/cowdata.hpp +++ b/include/godot_cpp/templates/cowdata.hpp @@ -294,7 +294,7 @@ Error CowData<T>::resize(int p_size) { if (current_size == 0) { // alloc from scratch uint32_t *ptr = (uint32_t *)Memory::alloc_static(alloc_size, true); - ERR_FAIL_COND_V(!ptr, ERR_OUT_OF_MEMORY); + ERR_FAIL_NULL_V(ptr, ERR_OUT_OF_MEMORY); *(ptr - 1) = 0; // size, currently none new (ptr - 2) SafeNumeric<uint32_t>(1); // refcount @@ -302,7 +302,7 @@ Error CowData<T>::resize(int p_size) { } else { uint32_t *_ptrnew = (uint32_t *)Memory::realloc_static(_ptr, alloc_size, true); - ERR_FAIL_COND_V(!_ptrnew, ERR_OUT_OF_MEMORY); + ERR_FAIL_NULL_V(_ptrnew, ERR_OUT_OF_MEMORY); new (_ptrnew - 2) SafeNumeric<uint32_t>(rc); // refcount _ptr = (T *)(_ptrnew); @@ -332,7 +332,7 @@ Error CowData<T>::resize(int p_size) { if (alloc_size != current_alloc_size) { uint32_t *_ptrnew = (uint32_t *)Memory::realloc_static(_ptr, alloc_size, true); - ERR_FAIL_COND_V(!_ptrnew, ERR_OUT_OF_MEMORY); + ERR_FAIL_NULL_V(_ptrnew, ERR_OUT_OF_MEMORY); new (_ptrnew - 2) SafeNumeric<uint32_t>(rc); // refcount _ptr = (T *)(_ptrnew); diff --git a/include/godot_cpp/templates/list.hpp b/include/godot_cpp/templates/list.hpp index 36285f8..2c8a7c8 100644 --- a/include/godot_cpp/templates/list.hpp +++ b/include/godot_cpp/templates/list.hpp @@ -221,7 +221,7 @@ private: int size_cache = 0; bool erase(const Element *p_I) { - ERR_FAIL_COND_V(!p_I, false); + ERR_FAIL_NULL_V(p_I, false); ERR_FAIL_COND_V(p_I->data != this, false); if (first == p_I) { diff --git a/include/godot_cpp/templates/rid_owner.hpp b/include/godot_cpp/templates/rid_owner.hpp index 93a8356..005fc87 100644 --- a/include/godot_cpp/templates/rid_owner.hpp +++ b/include/godot_cpp/templates/rid_owner.hpp @@ -186,12 +186,12 @@ public: } void initialize_rid(RID p_rid) { T *mem = get_or_null(p_rid, true); - ERR_FAIL_COND(!mem); + ERR_FAIL_NULL(mem); memnew_placement(mem, T); } void initialize_rid(RID p_rid, const T &p_value) { T *mem = get_or_null(p_rid, true); - ERR_FAIL_COND(!mem); + ERR_FAIL_NULL(mem); memnew_placement(mem, T(p_value)); } @@ -374,7 +374,7 @@ public: _FORCE_INLINE_ void replace(const RID &p_rid, T *p_new_ptr) { T **ptr = alloc.get_or_null(p_rid); - ERR_FAIL_COND(!ptr); + ERR_FAIL_NULL(ptr); *ptr = p_new_ptr; } diff --git a/include/godot_cpp/templates/thread_work_pool.hpp b/include/godot_cpp/templates/thread_work_pool.hpp index 85245b4..a3efd42 100644 --- a/include/godot_cpp/templates/thread_work_pool.hpp +++ b/include/godot_cpp/templates/thread_work_pool.hpp @@ -96,7 +96,7 @@ class ThreadWorkPool { public: template <class C, class M, class U> void begin_work(uint32_t p_elements, C *p_instance, M p_method, U p_userdata) { - ERR_FAIL_COND(!threads); // never initialized + ERR_FAIL_NULL(threads); // Never initialized. ERR_FAIL_COND(current_work != nullptr); index.store(0, std::memory_order_release); @@ -123,18 +123,18 @@ public: } bool is_done_dispatching() const { - ERR_FAIL_COND_V(current_work == nullptr, true); + ERR_FAIL_NULL_V(current_work, true); return index.load(std::memory_order_acquire) >= current_work->max_elements; } uint32_t get_work_index() const { - ERR_FAIL_COND_V(current_work == nullptr, 0); + ERR_FAIL_NULL_V(current_work, 0); uint32_t idx = index.load(std::memory_order_acquire); return Math::min(idx, current_work->max_elements); } void end_work() { - ERR_FAIL_COND(current_work == nullptr); + ERR_FAIL_NULL(current_work); for (uint32_t i = 0; i < threads_working; i++) { threads[i].completed.wait(); threads[i].work = nullptr; |