diff options
author | Rémi Verschelde <rverschelde@gmail.com> | 2022-10-07 22:25:54 +0200 |
---|---|---|
committer | Rémi Verschelde <rverschelde@gmail.com> | 2022-10-07 22:25:54 +0200 |
commit | db8679443fb6fcd5f9a97abf3e25c9e64f256607 (patch) | |
tree | 3adaf7df7db0ce66302490f3e5e9cbf263645929 /src/variant/basis.cpp | |
parent | 0eba81ef79b96922a0e1637f812e4e1df4d29a4c (diff) | |
parent | 65eeb94f75d00cf523da114de3587f930cdec13f (diff) | |
download | redot-cpp-db8679443fb6fcd5f9a97abf3e25c9e64f256607.tar.gz |
Merge pull request #885 from aaronfranke/core-data-structs
Update core data structures to match the engine
Diffstat (limited to 'src/variant/basis.cpp')
-rw-r--r-- | src/variant/basis.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/variant/basis.cpp b/src/variant/basis.cpp index 27212c0..add45a5 100644 --- a/src/variant/basis.cpp +++ b/src/variant/basis.cpp @@ -122,7 +122,7 @@ bool Basis::is_diagonal() const { } bool Basis::is_rotation() const { - return Math::is_equal_approx(determinant(), (real_t)1, (real_t)UNIT_EPSILON) && is_orthogonal(); + return Math::is_equal_approx(determinant(), 1, (real_t)UNIT_EPSILON) && is_orthogonal(); } #ifdef MATH_CHECKS @@ -315,7 +315,7 @@ Vector3 Basis::get_scale() const { // // A proper way to get rid of this issue would be to store the scaling values (or at least their signs) // as a part of Basis. However, if we go that path, we need to disable direct (write) access to the - // matrix rows. + // matrix elements. // // The rotation part of this decomposition is returned by get_rotation* functions. real_t det_sign = SIGN(determinant()); |