summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorDavid Snopek <dsnopek@gmail.com>2023-09-21 15:06:51 -0500
committerGitHub <noreply@github.com>2023-09-21 15:06:51 -0500
commitdb15731e4d2af5510a9c9310c7fd71813d1dd9c7 (patch)
tree91c19f5e8d11fdcecdf25f479fd2401d6d39726a /src
parent381df0081a6267f889a8432e56e0fbcf369e1f4e (diff)
parent52ca3ef547b5586fd0a085c5b01a08b8f95332ca (diff)
downloadredot-cpp-db15731e4d2af5510a9c9310c7fd71813d1dd9c7.tar.gz
Merge pull request #1165 from dsnopek/missing-classes
Handle missing instance binding callbacks by finding the closest parent
Diffstat (limited to 'src')
-rw-r--r--src/core/class_db.cpp13
1 files changed, 12 insertions, 1 deletions
diff --git a/src/core/class_db.cpp b/src/core/class_db.cpp
index 76abd21..9aaacef 100644
--- a/src/core/class_db.cpp
+++ b/src/core/class_db.cpp
@@ -310,7 +310,18 @@ GDExtensionClassCallVirtual ClassDB::get_virtual_func(void *p_userdata, GDExtens
const GDExtensionInstanceBindingCallbacks *ClassDB::get_instance_binding_callbacks(const StringName &p_class) {
std::unordered_map<StringName, const GDExtensionInstanceBindingCallbacks *>::iterator callbacks_it = instance_binding_callbacks.find(p_class);
- ERR_FAIL_COND_V_MSG(callbacks_it == instance_binding_callbacks.end(), nullptr, String("Cannot find instance binding callbacks for class '{0}'.").format(Array::make(p_class)));
+ if (likely(callbacks_it != instance_binding_callbacks.end())) {
+ return callbacks_it->second;
+ }
+
+ // If we don't have an instance binding callback for the given class, find the closest parent where we do.
+ StringName class_name = p_class;
+ do {
+ class_name = get_parent_class(class_name);
+ ERR_FAIL_COND_V_MSG(class_name == StringName(), nullptr, String("Cannot find instance binding callbacks for class '{0}'.").format(Array::make(p_class)));
+ callbacks_it = instance_binding_callbacks.find(class_name);
+ } while (callbacks_it == instance_binding_callbacks.end());
+
return callbacks_it->second;
}