diff options
| author | Yuri Sizov <11782833+YuriSizov@users.noreply.github.com> | 2023-04-10 13:03:00 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-10 13:03:00 +0200 |
| commit | 220953b6258712dc060bf8ea7592c280ba3ca3ad (patch) | |
| tree | 8f8be62a4cd47ce506cf4d65b18c6cc659e4fe85 | |
| parent | 5243f5cece3c0a61ab18aba4a49edec0b4601fa6 (diff) | |
| parent | 936c9e83b4db06215554ae6f6e888324655048d8 (diff) | |
| download | redot-engine-220953b6258712dc060bf8ea7592c280ba3ca3ad.tar.gz | |
Merge pull request #75814 from timothyqiu/connect-unicode
Fix connect signal dialog not allowing Unicode method name
| -rw-r--r-- | editor/connections_dialog.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/editor/connections_dialog.cpp b/editor/connections_dialog.cpp index befe84f311..fc7a9b05d3 100644 --- a/editor/connections_dialog.cpp +++ b/editor/connections_dialog.cpp @@ -119,7 +119,7 @@ void ConnectDialog::ok_pressed() { return; } - if (!method_name.strip_edges().is_valid_identifier()) { + if (!TS->is_valid_identifier(method_name.strip_edges())) { error->set_text(TTR("Method name must be a valid identifier.")); error->popup_centered(); return; @@ -228,7 +228,7 @@ StringName ConnectDialog::generate_method_callback_name(Node *p_source, String p String node_name = p_source->get_name(); for (int i = 0; i < node_name.length(); i++) { // TODO: Regex filter may be cleaner. char32_t c = node_name[i]; - if (!is_ascii_identifier_char(c)) { + if ((i == 0 && !is_unicode_identifier_start(c)) || (i > 0 && !is_unicode_identifier_continue(c))) { if (c == ' ') { // Replace spaces with underlines. c = '_'; |