summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRémi Verschelde <rverschelde@gmail.com>2024-04-18 12:25:08 +0200
committerRémi Verschelde <rverschelde@gmail.com>2024-04-18 12:25:08 +0200
commit2543d192c3f74640393f245e48fdf70e241dbe37 (patch)
tree5f337d45aa6ece27e830342cbd1fa3dcc80a84d1
parenta202027efe61d0e26d6749beea83081570b5e9f3 (diff)
parent00f0043227a611c31922485b15e180f6250f6a89 (diff)
downloadredot-engine-2543d192c3f74640393f245e48fdf70e241dbe37.tar.gz
Merge pull request #90842 from timothyqiu/revert-79792
Revert "Correctly display tooltips for buttons in Tree when they overlap cell content
-rw-r--r--scene/gui/tree.cpp13
-rw-r--r--scene/gui/tree.h1
2 files changed, 10 insertions, 4 deletions
diff --git a/scene/gui/tree.cpp b/scene/gui/tree.cpp
index 1242d3bd16..9a2ba23ce8 100644
--- a/scene/gui/tree.cpp
+++ b/scene/gui/tree.cpp
@@ -2459,7 +2459,6 @@ int Tree::draw_item(const Point2i &p_pos, const Point2 &p_draw_ofs, const Size2
if (rtl) {
button_ofs.x = get_size().width - button_ofs.x - button_texture->get_width();
}
- p_item->cells.write[i].buttons.write[j].rect = Rect2i(button_ofs, button_size);
button_texture->draw(ci, button_ofs, p_item->cells[i].buttons[j].disabled ? Color(1, 1, 1, 0.5) : p_item->cells[i].buttons[j].color);
item_width_with_buttons -= button_size.width + theme_cache.button_margin;
}
@@ -5408,7 +5407,6 @@ String Tree::get_tooltip(const Point2 &p_pos) const {
return Control::get_tooltip(p_pos);
}
- Point2 button_pos = pos;
if (h_scroll->is_visible_in_tree()) {
pos.x += h_scroll->get_value();
}
@@ -5421,13 +5419,22 @@ String Tree::get_tooltip(const Point2 &p_pos) const {
if (it) {
const TreeItem::Cell &c = it->cells[col];
+ int col_width = get_column_width(col);
+
+ for (int i = 0; i < col; i++) {
+ pos.x -= get_column_width(i);
+ }
+
for (int j = c.buttons.size() - 1; j >= 0; j--) {
- if (c.buttons[j].rect.has_point(button_pos)) {
+ Ref<Texture2D> b = c.buttons[j].texture;
+ Size2 size = b->get_size() + theme_cache.button_pressed->get_minimum_size();
+ if (pos.x > col_width - size.width) {
String tooltip = c.buttons[j].tooltip;
if (!tooltip.is_empty()) {
return tooltip;
}
}
+ col_width -= size.width;
}
String ret;
if (it->get_tooltip_text(col) == "") {
diff --git a/scene/gui/tree.h b/scene/gui/tree.h
index 21696d8216..c7c266a2e7 100644
--- a/scene/gui/tree.h
+++ b/scene/gui/tree.h
@@ -108,7 +108,6 @@ private:
Ref<Texture2D> texture;
Color color = Color(1, 1, 1, 1);
String tooltip;
- Rect2i rect;
};
Vector<Button> buttons;