diff options
| author | Rémi Verschelde <rverschelde@gmail.com> | 2024-05-10 10:48:54 +0200 |
|---|---|---|
| committer | Rémi Verschelde <rverschelde@gmail.com> | 2024-05-10 10:48:54 +0200 |
| commit | 2ba22d1554ded08094e3869a83bd87487266ad38 (patch) | |
| tree | 6a4dd8d15badb6c6bb49517bd23fcb453fd429bc | |
| parent | 7724a50c283cee4113ca6a1a4c100e8b91461a71 (diff) | |
| parent | a76243a54963910f5d172fe1a4f6b320dba69db1 (diff) | |
| download | redot-engine-2ba22d1554ded08094e3869a83bd87487266ad38.tar.gz | |
Merge pull request #91790 from lawnjelly/fix_tight_light_cull_directional_colinear4
Tighter light culling - fix directional lights colinear case
| -rw-r--r-- | servers/rendering/rendering_light_culler.cpp | 16 |
1 files changed, 10 insertions, 6 deletions
diff --git a/servers/rendering/rendering_light_culler.cpp b/servers/rendering/rendering_light_culler.cpp index 0889898f0b..8dc2d85bdf 100644 --- a/servers/rendering/rendering_light_culler.cpp +++ b/servers/rendering/rendering_light_culler.cpp @@ -279,9 +279,11 @@ bool RenderingLightCuller::add_light_camera_planes_directional(LightCullPlanes & // Create a third point from the light direction. Vector3 pt2 = pt0 - p_light_source.dir; - // Create plane from 3 points. - Plane p(pt0, pt1, pt2); - r_cull_planes.add_cull_plane(p); + if (!_is_colinear_tri(pt0, pt1, pt2)) { + // Create plane from 3 points. + Plane p(pt0, pt1, pt2); + r_cull_planes.add_cull_plane(p); + } } // Last to 0 edge. @@ -295,9 +297,11 @@ bool RenderingLightCuller::add_light_camera_planes_directional(LightCullPlanes & // Create a third point from the light direction. Vector3 pt2 = pt0 - p_light_source.dir; - // Create plane from 3 points. - Plane p(pt0, pt1, pt2); - r_cull_planes.add_cull_plane(p); + if (!_is_colinear_tri(pt0, pt1, pt2)) { + // Create plane from 3 points. + Plane p(pt0, pt1, pt2); + r_cull_planes.add_cull_plane(p); + } } #ifdef LIGHT_CULLER_DEBUG_LOGGING |