diff options
| author | Rémi Verschelde <remi@verschelde.fr> | 2024-02-23 23:42:59 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-02-23 23:42:59 +0100 |
| commit | 2e7fc81315bfa8d0a15f60adff2a12b6f3104236 (patch) | |
| tree | 6611f9e9150d5573477b68331c32ab4d9d676c41 | |
| parent | 3abb32671e6c7aa109e494f7077da955b173cfa9 (diff) | |
| parent | fa81e125889383f4ffd1404dd71def1ae60964c0 (diff) | |
| download | redot-engine-2e7fc81315bfa8d0a15f60adff2a12b6f3104236.tar.gz | |
Merge pull request #88740 from dsnopek/webxr-linting-issues
Fix lint errors in WebXR module
| -rw-r--r-- | .github/workflows/static_checks.yml | 2 | ||||
| -rw-r--r-- | modules/webxr/native/library_godot_webxr.js | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/.github/workflows/static_checks.yml b/.github/workflows/static_checks.yml index e7ebd2fb64..cf8b0f4132 100644 --- a/.github/workflows/static_checks.yml +++ b/.github/workflows/static_checks.yml @@ -76,7 +76,7 @@ jobs: - name: JavaScript style and documentation checks via ESLint and JSDoc run: | - if grep -q "platform/web" changed.txt || [ -z "$(cat changed.txt)" ]; then + if grep -q "\.js" changed.txt || [ -z "$(cat changed.txt)" ]; then cd platform/web npm ci npm run lint diff --git a/modules/webxr/native/library_godot_webxr.js b/modules/webxr/native/library_godot_webxr.js index c048bb2197..722b448fd5 100644 --- a/modules/webxr/native/library_godot_webxr.js +++ b/modules/webxr/native/library_godot_webxr.js @@ -319,7 +319,7 @@ const GodotWebXR = { // next reference space. window.setTimeout(function () { const reference_space_c_str = GodotRuntime.allocString(reference_space_type); - const enabled_features_c_str = GodotRuntime.allocString(Array.from(session.enabledFeatures).join(",")); + const enabled_features_c_str = GodotRuntime.allocString(Array.from(session.enabledFeatures).join(',')); onstarted(reference_space_c_str, enabled_features_c_str); GodotRuntime.free(reference_space_c_str); GodotRuntime.free(enabled_features_c_str); @@ -567,7 +567,7 @@ const GodotWebXR = { // Hand tracking data. let has_hand_data = false; - if (input_source.hand && r_hand_joints != 0 && r_hand_radii != 0) { + if (input_source.hand && r_hand_joints !== 0 && r_hand_radii !== 0) { const hand_joint_array = new Float32Array(25 * 16); const hand_radii_array = new Float32Array(25); if (frame.fillPoses(input_source.hand.values(), space, hand_joint_array) && frame.fillJointRadii(input_source.hand.values(), hand_radii_array)) { |