summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRémi Verschelde <rverschelde@gmail.com>2024-02-07 11:09:28 +0100
committerRémi Verschelde <rverschelde@gmail.com>2024-02-07 11:09:34 +0100
commit7223c5b54a7958fe8f8176bafe5ea415f0c514a6 (patch)
tree356bb60754ce9a90d84805581489a896b7e8f939
parent08eaeff6402b92d3df4268321ee1ceea8f2bfd5a (diff)
downloadredot-engine-7223c5b54a7958fe8f8176bafe5ea415f0c514a6.tar.gz
Fix various typos with codespell
Using 2.2.7.dev115+g0eb441d6. Had to add `cancelled` to the ignore list, as it's a Wayland signal which we're handling in our code, so we don't want codespell to fix that "typo". Also includes the typo fix from #87927. Co-authored-by: Divyanshu Shekhar <61140213+divshekhar@users.noreply.github.com>
-rw-r--r--drivers/gles3/storage/render_scene_buffers_gles3.h2
-rwxr-xr-xmisc/scripts/codespell.sh2
-rw-r--r--modules/gdscript/README.md2
-rw-r--r--modules/gdscript/tests/README.md4
-rw-r--r--platform/linuxbsd/wayland/SCsub4
-rw-r--r--platform/web/js/engine/config.js2
-rw-r--r--servers/rendering/rendering_light_culler.cpp4
7 files changed, 10 insertions, 10 deletions
diff --git a/drivers/gles3/storage/render_scene_buffers_gles3.h b/drivers/gles3/storage/render_scene_buffers_gles3.h
index 7a6811bf3c..39aa1fb973 100644
--- a/drivers/gles3/storage/render_scene_buffers_gles3.h
+++ b/drivers/gles3/storage/render_scene_buffers_gles3.h
@@ -108,7 +108,7 @@ public:
void free_render_buffer_data();
- void check_backbuffer(bool p_need_color, bool p_need_depth); // check if we need to initialise our backbuffer
+ void check_backbuffer(bool p_need_color, bool p_need_depth); // Check if we need to initialize our backbuffer.
GLuint get_render_fbo();
GLuint get_msaa3d_fbo() const { return msaa3d.fbo; }
diff --git a/misc/scripts/codespell.sh b/misc/scripts/codespell.sh
index 2de440679f..7dad25fa23 100755
--- a/misc/scripts/codespell.sh
+++ b/misc/scripts/codespell.sh
@@ -3,6 +3,6 @@ SKIP_LIST="./.*,./**/.*,./bin,./thirdparty,*.desktop,*.gen.*,*.po,*.pot,*.rc,./A
SKIP_LIST+="./core/input/gamecontrollerdb.txt,./core/string/locales.h,./editor/renames_map_3_to_4.cpp,./misc/scripts/codespell.sh,"
SKIP_LIST+="./platform/android/java/lib/src/com,./platform/web/node_modules,./platform/web/package-lock.json,"
-IGNORE_LIST="breaked,curvelinear,doubleclick,expct,findn,gird,hel,inout,lod,mis,nd,numer,ot,requestor,te,vai"
+IGNORE_LIST="breaked,cancelled,curvelinear,doubleclick,expct,findn,gird,hel,inout,lod,mis,nd,numer,ot,requestor,te,vai"
codespell -w -q 3 -S "${SKIP_LIST}" -L "${IGNORE_LIST}" --builtin "clear,rare,en-GB_to_en-US"
diff --git a/modules/gdscript/README.md b/modules/gdscript/README.md
index 30685e672c..865475d37d 100644
--- a/modules/gdscript/README.md
+++ b/modules/gdscript/README.md
@@ -69,7 +69,7 @@ The remaining steps of resolution, including member variable initialization code
In fully untyped code, very little static analysis is possible. For example, the analyzer cannot know whether `my_var.some_member` exists when it does not know the type of `my_var`. Therefore, it cannot emit a warning or error because `some_member` _could_ exist - or it could not. The analyzer must trust the programmer. If an error does occur, it will be at runtime.
However, GDScript is gradually typed, so all of these analyses must work when parts of the code are typed and others untyped. Static analysis in a gradually typed language is a best-effort situation: suppose there is a typed variable `var x : int`, and an untyped `var y = "some string"`. We can obviously tell this isn't going to work, but the analyzer will accept the assignment `x = y` without warnings or errors: it only knows that `y` is untyped and can therefore be anything, including the `int` that `x` expects. It must once again trust the programmer to have written code that works. In this instance, the code will error at runtime.
-In both these cases, the analyzer handles the uncertainty of untyped code by calling `mark_node_unsafe()` on the respective AST node. This means it didn't have enough information to know whether the code was fully safe or necessarily wrong. Lines with unsafe AST nodes are represented by grey line numbers in the GDScript editor. Green line numbers indicate a line of code without any unsafe nodes.
+In both these cases, the analyzer handles the uncertainty of untyped code by calling `mark_node_unsafe()` on the respective AST node. This means it didn't have enough information to know whether the code was fully safe or necessarily wrong. Lines with unsafe AST nodes are represented by gray line numbers in the GDScript editor. Green line numbers indicate a line of code without any unsafe nodes.
This analysis step is also where dependencies are introduced and that information stored for use later. If class `A` extends class `B` or contains a member with type `B` from some other script file, then the analyzer will attempt to load that second script. If `B` contains references to `A`, then a _cyclic_ dependency is introduced. This is OK in many cases, but impossible to resolve in others.
diff --git a/modules/gdscript/tests/README.md b/modules/gdscript/tests/README.md
index cea251bab5..72b5316532 100644
--- a/modules/gdscript/tests/README.md
+++ b/modules/gdscript/tests/README.md
@@ -32,9 +32,9 @@ Tests will only test against entries in `[output]` that were specified.
## Writing autocompletion tests
-To avoid failing edge cases a certain behaviour needs to be tested multiple times. Some things that tests should account for:
+To avoid failing edge cases a certain behavior needs to be tested multiple times. Some things that tests should account for:
-- All possible types: Test with all possible types that apply to the tested behaviour. (For the last points testing against `SCRIPT` and `CLASS` should suffice. `CLASS` can be obtained through C#, `SCRIPT` through GDScript. Relying on autoloads to be of type `SCRIPT` is not good, since this might change in the future.)
+- All possible types: Test with all possible types that apply to the tested behavior. (For the last points testing against `SCRIPT` and `CLASS` should suffice. `CLASS` can be obtained through C#, `SCRIPT` through GDScript. Relying on autoloads to be of type `SCRIPT` is not good, since this might change in the future.)
- `BUILTIN`
- `NATIVE`
diff --git a/platform/linuxbsd/wayland/SCsub b/platform/linuxbsd/wayland/SCsub
index d2b000ff66..99b7349dbe 100644
--- a/platform/linuxbsd/wayland/SCsub
+++ b/platform/linuxbsd/wayland/SCsub
@@ -19,7 +19,7 @@ if env["use_sowrap"]:
"WAYLAND_API_CODE": Builder(
action=Action(
"wayland-scanner -c private-code < ${SOURCE} | sed 's:wayland-util\.h:../dynwrappers/wayland-client-core-so_wrap\.h:' > ${TARGET}",
- 'Generating Wayland protocol marshalling code: "${TARGET}"',
+ 'Generating Wayland protocol marshaling code: "${TARGET}"',
),
single_source=True,
),
@@ -37,7 +37,7 @@ else:
"WAYLAND_API_CODE": Builder(
action=Action(
"wayland-scanner -c private-code < ${SOURCE} > ${TARGET}",
- 'Generating Wayland protocol marshalling code: "${TARGET}"',
+ 'Generating Wayland protocol marshaling code: "${TARGET}"',
),
single_source=True,
),
diff --git a/platform/web/js/engine/config.js b/platform/web/js/engine/config.js
index 0b6626968e..a7134da6fa 100644
--- a/platform/web/js/engine/config.js
+++ b/platform/web/js/engine/config.js
@@ -19,7 +19,7 @@ const EngineConfig = {}; // eslint-disable-line no-unused-vars
const InternalConfig = function (initConfig) { // eslint-disable-line no-unused-vars
const cfg = /** @lends {InternalConfig.prototype} */ {
/**
- * Whether the unload the engine automatically after the instance is initialized.
+ * Whether to unload the engine automatically after the instance is initialized.
*
* @memberof EngineConfig
* @default
diff --git a/servers/rendering/rendering_light_culler.cpp b/servers/rendering/rendering_light_culler.cpp
index 0d704c85de..3d82683bc2 100644
--- a/servers/rendering/rendering_light_culler.cpp
+++ b/servers/rendering/rendering_light_culler.cpp
@@ -639,7 +639,7 @@ uint8_t RenderingLightCuller::Data::LUT_entries[LUT_SIZE][8] = {
void RenderingLightCuller::create_LUT() {
// Each pair of planes that are opposite can have an edge.
for (int plane_0 = 0; plane_0 < PLANE_TOTAL; plane_0++) {
- // For each neighbour of the plane.
+ // For each neighbor of the plane.
PlaneOrder neighs[4];
get_neighbouring_planes((PlaneOrder)plane_0, neighs);
@@ -864,7 +864,7 @@ void RenderingLightCuller::compact_LUT_entry(uint32_t p_entry_id) {
}
void RenderingLightCuller::get_neighbouring_planes(PlaneOrder p_plane, PlaneOrder r_neigh_planes[4]) const {
- // Table of neighbouring planes to each.
+ // Table of neighboring planes to each.
static const PlaneOrder neigh_table[PLANE_TOTAL][4] = {
{ // LSM_FP_NEAR
PLANE_LEFT,