summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRémi Verschelde <rverschelde@gmail.com>2017-03-04 17:19:04 +0100
committerGitHub <noreply@github.com>2017-03-04 17:19:04 +0100
commit81a393a2b445c78f4f1bfc21a9e8cc2784ca39c9 (patch)
treedce3154c4021ac4e5f3ceaa21e34008bb7cdda21
parent723f74c8510cb917aded4339fd3e4b3c21891e08 (diff)
parent9cddaab4d1811b367c9616d35e28a8c428cf3b3f (diff)
downloadredot-engine-81a393a2b445c78f4f1bfc21a9e8cc2784ca39c9.tar.gz
Merge pull request #7508 from lonesurvivor/area2d-fix
Fix two problems with Area2D and remove_child()
-rw-r--r--scene/2d/area_2d.cpp13
1 files changed, 7 insertions, 6 deletions
diff --git a/scene/2d/area_2d.cpp b/scene/2d/area_2d.cpp
index 68228520b3..55c7716b6b 100644
--- a/scene/2d/area_2d.cpp
+++ b/scene/2d/area_2d.cpp
@@ -357,6 +357,10 @@ void Area2D::_clear_monitoring() {
Object *obj = ObjectDB::get_instance(E->key());
Node *node = obj ? obj->cast_to<Node>() : NULL;
ERR_CONTINUE(!node);
+
+ node->disconnect(SceneStringNames::get_singleton()->tree_entered,this,SceneStringNames::get_singleton()->_body_enter_tree);
+ node->disconnect(SceneStringNames::get_singleton()->tree_exited,this,SceneStringNames::get_singleton()->_body_exit_tree);
+
if (!E->get().in_tree)
continue;
@@ -366,9 +370,6 @@ void Area2D::_clear_monitoring() {
}
emit_signal(SceneStringNames::get_singleton()->body_exited,obj);
-
- node->disconnect(SceneStringNames::get_singleton()->tree_entered,this,SceneStringNames::get_singleton()->_body_enter_tree);
- node->disconnect(SceneStringNames::get_singleton()->tree_exited,this,SceneStringNames::get_singleton()->_body_exit_tree);
}
}
@@ -388,6 +389,9 @@ void Area2D::_clear_monitoring() {
continue;
//ERR_CONTINUE(!node);
+ node->disconnect(SceneStringNames::get_singleton()->tree_entered,this,SceneStringNames::get_singleton()->_area_enter_tree);
+ node->disconnect(SceneStringNames::get_singleton()->tree_exited,this,SceneStringNames::get_singleton()->_area_exit_tree);
+
if (!E->get().in_tree)
continue;
@@ -397,9 +401,6 @@ void Area2D::_clear_monitoring() {
}
emit_signal(SceneStringNames::get_singleton()->area_exited,obj);
-
- node->disconnect(SceneStringNames::get_singleton()->tree_entered,this,SceneStringNames::get_singleton()->_area_enter_tree);
- node->disconnect(SceneStringNames::get_singleton()->tree_exited,this,SceneStringNames::get_singleton()->_area_exit_tree);
}
}