summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordevloglogan <devloglogan@gmail.com>2024-04-29 15:38:15 -0500
committerLogan Lang <devloglogan@gmail.com>2024-04-30 08:59:40 -0500
commita35196ba220f16940b5b048f441007b6600fec7c (patch)
treeabf507ad91d8978b98210badb839183f267658f1
parent6118592c6d88350d01f74faff6fd49754f84a7d0 (diff)
downloadredot-engine-a35196ba220f16940b5b048f441007b6600fec7c.tar.gz
Store previous relative transforms in XRHandModifier3D
-rw-r--r--scene/3d/xr_hand_modifier_3d.cpp24
-rw-r--r--scene/3d/xr_hand_modifier_3d.h3
2 files changed, 27 insertions, 0 deletions
diff --git a/scene/3d/xr_hand_modifier_3d.cpp b/scene/3d/xr_hand_modifier_3d.cpp
index 1e78a4630f..baaa9eee48 100644
--- a/scene/3d/xr_hand_modifier_3d.cpp
+++ b/scene/3d/xr_hand_modifier_3d.cpp
@@ -70,6 +70,11 @@ void XRHandModifier3D::_get_joint_data() {
return;
}
+ if (has_stored_previous_transforms) {
+ previous_relative_transforms.clear();
+ has_stored_previous_transforms = false;
+ }
+
// Table of bone names for different rig types.
static const String bone_names[XRHandTracker::HAND_JOINT_MAX] = {
"Palm",
@@ -196,6 +201,18 @@ void XRHandModifier3D::_process_modification() {
// Skip if no tracking data
if (!tracker->get_has_tracking_data()) {
+ if (!has_stored_previous_transforms) {
+ return;
+ }
+
+ // Apply previous relative transforms if they are stored.
+ for (int joint = 0; joint < XRHandTracker::HAND_JOINT_MAX; joint++) {
+ if (bone_update == BONE_UPDATE_FULL) {
+ skeleton->set_bone_pose_position(joints[joint].bone, previous_relative_transforms[joint].origin);
+ }
+
+ skeleton->set_bone_pose_rotation(joints[joint].bone, Quaternion(previous_relative_transforms[joint].basis));
+ }
return;
}
@@ -223,6 +240,12 @@ void XRHandModifier3D::_process_modification() {
return;
}
+ if (!has_stored_previous_transforms) {
+ previous_relative_transforms.resize(XRHandTracker::HAND_JOINT_MAX);
+ has_stored_previous_transforms = true;
+ }
+ Transform3D *previous_relative_transforms_ptr = previous_relative_transforms.ptrw();
+
for (int joint = 0; joint < XRHandTracker::HAND_JOINT_MAX; joint++) {
// Get the skeleton bone (skip if none).
const int bone = joints[joint].bone;
@@ -233,6 +256,7 @@ void XRHandModifier3D::_process_modification() {
// Calculate the relative relationship to the parent bone joint.
const int parent_joint = joints[joint].parent_joint;
const Transform3D relative_transform = inv_transforms[parent_joint] * transforms[joint];
+ previous_relative_transforms_ptr[joint] = relative_transform;
// Update the bone position if enabled by update mode.
if (bone_update == BONE_UPDATE_FULL) {
diff --git a/scene/3d/xr_hand_modifier_3d.h b/scene/3d/xr_hand_modifier_3d.h
index 67d1694d41..3d78f32b64 100644
--- a/scene/3d/xr_hand_modifier_3d.h
+++ b/scene/3d/xr_hand_modifier_3d.h
@@ -73,6 +73,9 @@ private:
BoneUpdate bone_update = BONE_UPDATE_FULL;
JointData joints[XRHandTracker::HAND_JOINT_MAX];
+ bool has_stored_previous_transforms = false;
+ Vector<Transform3D> previous_relative_transforms;
+
void _get_joint_data();
void _tracker_changed(StringName p_tracker_name, XRServer::TrackerType p_tracker_type);
};