diff options
| author | Rémi Verschelde <rverschelde@gmail.com> | 2024-04-23 19:11:17 +0200 |
|---|---|---|
| committer | Rémi Verschelde <rverschelde@gmail.com> | 2024-04-23 19:11:17 +0200 |
| commit | a55ffba31bffaa64bfa6995ca91c6ace2d603b96 (patch) | |
| tree | 0495ffdb066eadf52a58aabef8050edfd2de9b89 | |
| parent | fc912defb1a0c84e5330ed6e52340cb82381a468 (diff) | |
| parent | 1ab5a4734706477b572dadc04c43c8d62f772cb6 (diff) | |
| download | redot-engine-a55ffba31bffaa64bfa6995ca91c6ace2d603b96.tar.gz | |
Merge pull request #90620 from thimenesup/fix_push_constant
Fix incorrect bounds check in RenderingDevice push constant
| -rw-r--r-- | servers/rendering/rendering_device.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/servers/rendering/rendering_device.cpp b/servers/rendering/rendering_device.cpp index 2b6644e893..82e0737ecf 100644 --- a/servers/rendering/rendering_device.cpp +++ b/servers/rendering/rendering_device.cpp @@ -6400,11 +6400,11 @@ Vector<int64_t> RenderingDevice::_draw_list_switch_to_next_pass_split(uint32_t p #endif void RenderingDevice::_draw_list_set_push_constant(DrawListID p_list, const Vector<uint8_t> &p_data, uint32_t p_data_size) { - ERR_FAIL_COND((uint32_t)p_data.size() > p_data_size); + ERR_FAIL_COND(p_data_size > (uint32_t)p_data.size()); draw_list_set_push_constant(p_list, p_data.ptr(), p_data_size); } void RenderingDevice::_compute_list_set_push_constant(ComputeListID p_list, const Vector<uint8_t> &p_data, uint32_t p_data_size) { - ERR_FAIL_COND((uint32_t)p_data.size() > p_data_size); + ERR_FAIL_COND(p_data_size > (uint32_t)p_data.size()); compute_list_set_push_constant(p_list, p_data.ptr(), p_data_size); } |