diff options
| author | Rémi Verschelde <rverschelde@gmail.com> | 2024-05-10 09:56:12 +0200 |
|---|---|---|
| committer | Rémi Verschelde <rverschelde@gmail.com> | 2024-05-10 09:56:12 +0200 |
| commit | d24403d0564ec7bd62c34dc0503dd70fb7e0c78c (patch) | |
| tree | 4032e6edec60f9355980a22d7410951a1ca95c0b | |
| parent | 3a5593a721ce9b2d2c4a4c188bfdddc3cd6cf4e2 (diff) | |
| parent | af5f695a99addd052929c5dee9f3d7c9cd896814 (diff) | |
| download | redot-engine-d24403d0564ec7bd62c34dc0503dd70fb7e0c78c.tar.gz | |
Merge pull request #91763 from paulloz/dotnet/fix-stringextension-warnings
C#: Fix comparison warnings in `StringExtensions.cs`
| -rw-r--r-- | modules/mono/glue/GodotSharp/GodotSharp/Core/StringExtensions.cs | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/modules/mono/glue/GodotSharp/GodotSharp/Core/StringExtensions.cs b/modules/mono/glue/GodotSharp/GodotSharp/Core/StringExtensions.cs index c805b68c94..ad75195f0f 100644 --- a/modules/mono/glue/GodotSharp/GodotSharp/Core/StringExtensions.cs +++ b/modules/mono/glue/GodotSharp/GodotSharp/Core/StringExtensions.cs @@ -426,7 +426,9 @@ namespace Godot /// <returns>An integer that indicates the lexical relationship between the two comparands.</returns> public static int CasecmpTo(this string instance, string to) { - return instance.CompareTo(to, caseSensitive: true); +#pragma warning disable CA1309 // Use ordinal string comparison + return string.Compare(instance, to, ignoreCase: false, null); +#pragma warning restore CA1309 } /// <summary> @@ -441,7 +443,9 @@ namespace Godot [Obsolete("Use string.Compare instead.")] public static int CompareTo(this string instance, string to, bool caseSensitive = true) { - return string.Compare(instance, to, !caseSensitive); +#pragma warning disable CA1309 // Use ordinal string comparison + return string.Compare(instance, to, ignoreCase: !caseSensitive, null); +#pragma warning restore CA1309 } /// <summary> @@ -1261,7 +1265,9 @@ namespace Godot /// <returns>An integer that indicates the lexical relationship between the two comparands.</returns> public static int NocasecmpTo(this string instance, string to) { - return instance.CompareTo(to, caseSensitive: false); +#pragma warning disable CA1309 // Use ordinal string comparison + return string.Compare(instance, to, ignoreCase: true, null); +#pragma warning restore CA1309 } /// <summary> |