summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSofox <sofoxx@gmail.com>2024-06-14 21:55:01 +0100
committerSofox <sofoxx@gmail.com>2024-06-22 18:40:21 +0100
commitd86e02580c9211b7d7c2a48614649ec64c1fecec (patch)
tree7b9d869166ab761c82a1024dc4ed744a6a8408d6
parent4119fb32cb8b3213bc38886fe4c381db4fe5f24e (diff)
downloadredot-engine-d86e02580c9211b7d7c2a48614649ec64c1fecec.tar.gz
Fix engine crashing when using Down Arrow selection on Tree with no selection
-rw-r--r--scene/gui/tree.cpp13
1 files changed, 7 insertions, 6 deletions
diff --git a/scene/gui/tree.cpp b/scene/gui/tree.cpp
index 56be6b90a2..a3d1d5fcf2 100644
--- a/scene/gui/tree.cpp
+++ b/scene/gui/tree.cpp
@@ -3354,15 +3354,16 @@ void Tree::_go_up() {
prev = selected_item->get_prev_visible();
}
+ int col = MAX(selected_col, 0);
+
if (select_mode == SELECT_MULTI) {
if (!prev) {
return;
}
- select_single_item(prev, get_root(), selected_col);
+ select_single_item(prev, get_root(), col);
queue_redraw();
} else {
- int col = selected_col < 0 ? 0 : selected_col;
while (prev && !prev->cells[col].selectable) {
prev = prev->get_prev_visible();
}
@@ -3386,16 +3387,16 @@ void Tree::_go_down() {
next = selected_item->get_next_visible();
}
+ int col = MAX(selected_col, 0);
+
if (select_mode == SELECT_MULTI) {
if (!next) {
return;
}
- select_single_item(next, get_root(), selected_col);
+ select_single_item(next, get_root(), col);
queue_redraw();
} else {
- int col = selected_col < 0 ? 0 : selected_col;
-
while (next && !next->cells[col].selectable) {
next = next->get_next_visible();
}
@@ -4471,7 +4472,7 @@ TreeItem *Tree::get_last_item() const {
while (last) {
if (last->next) {
last = last->next;
- } else if (last->first_child) {
+ } else if (last->first_child && !last->collapsed) {
last = last->first_child;
} else {
break;