summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGeorge Marques <george@gmarqu.es>2016-06-24 12:39:58 -0300
committerGeorge Marques <george@gmarqu.es>2016-06-24 12:39:58 -0300
commitf4dfa37a23629e011dac74911a87860edf83c63d (patch)
tree26e211b7d8ac39a55757ac1c446139133323fae0
parent95e3279d34fd99bf816a19a7c0dc5a2d58e418e6 (diff)
downloadredot-engine-f4dfa37a23629e011dac74911a87860edf83c63d.tar.gz
Fix bug in String==StrRange comparison
It was comparing the StrRange with itself, always return true if both were the same length. Fix #3843
-rw-r--r--core/ustring.cpp7
1 files changed, 2 insertions, 5 deletions
diff --git a/core/ustring.cpp b/core/ustring.cpp
index ea9a9d903e..4dbe41890d 100644
--- a/core/ustring.cpp
+++ b/core/ustring.cpp
@@ -257,13 +257,10 @@ bool String::operator==(const StrRange &p_range) const {
return true;
const CharType *c_str=p_range.c_str;
-
- int l=length();
-
- const CharType *dst = p_range.c_str;
+ const CharType *dst = &operator[](0);
/* Compare char by char */
- for (int i=0;i<l;i++) {
+ for (int i=0;i<len;i++) {
if (c_str[i]!=dst[i])
return false;