summaryrefslogtreecommitdiffstats
path: root/core/string/ustring.cpp
diff options
context:
space:
mode:
authorAaron Franke <arnfranke@yahoo.com>2021-07-15 23:45:57 -0400
committerAaron Franke <arnfranke@yahoo.com>2021-07-23 17:38:28 -0400
commit4e6efd1b07f1c6d53d226977ddc729333b74306a (patch)
treea52f672e7f622bb65e3b65f2a2edc9d19b1ecdcf /core/string/ustring.cpp
parentb918c4c3ce84af1f8af2d06ef31784f48a15551a (diff)
downloadredot-engine-4e6efd1b07f1c6d53d226977ddc729333b74306a.tar.gz
Use C++ iterators for Lists in many situations
Diffstat (limited to 'core/string/ustring.cpp')
-rw-r--r--core/string/ustring.cpp7
1 files changed, 2 insertions, 5 deletions
diff --git a/core/string/ustring.cpp b/core/string/ustring.cpp
index 4cd2915ffa..dbb8dc8283 100644
--- a/core/string/ustring.cpp
+++ b/core/string/ustring.cpp
@@ -3421,11 +3421,8 @@ String String::format(const Variant &values, String placeholder) const {
List<Variant> keys;
d.get_key_list(&keys);
- for (List<Variant>::Element *E = keys.front(); E; E = E->next()) {
- String key = E->get();
- String val = d[E->get()];
-
- new_string = new_string.replace(placeholder.replace("_", key), val);
+ for (Variant &key : keys) {
+ new_string = new_string.replace(placeholder.replace("_", key), d[key]);
}
} else {
ERR_PRINT(String("Invalid type: use Array or Dictionary.").ascii().get_data());