diff options
| author | A Thousand Ships <96648715+AThousandShips@users.noreply.github.com> | 2024-04-15 15:18:34 +0200 |
|---|---|---|
| committer | A Thousand Ships <96648715+AThousandShips@users.noreply.github.com> | 2024-05-04 16:08:55 +0200 |
| commit | 955d5affa857ec1f358c56da8fb1ff4ab6590704 (patch) | |
| tree | b667ac9f6f62bff17ce032683c0eb09727660555 /editor/editor_about.cpp | |
| parent | 7ebc866418b075df58cbe4e31fcf8b0c3acd70a1 (diff) | |
| download | redot-engine-955d5affa857ec1f358c56da8fb1ff4ab6590704.tar.gz | |
Reduce and prevent unnecessary random-access to `List`
Random-access access to `List` when iterating is `O(n^2)` (`O(n)` when
accessing a single element)
* Removed subscript operator, in favor of a more explicit `get`
* Added conversion from `Iterator` to `ConstIterator`
* Remade existing operations into other solutions when applicable
Diffstat (limited to 'editor/editor_about.cpp')
| -rw-r--r-- | editor/editor_about.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/editor/editor_about.cpp b/editor/editor_about.cpp index af0419a81a..af4631a539 100644 --- a/editor/editor_about.cpp +++ b/editor/editor_about.cpp @@ -107,13 +107,14 @@ ScrollContainer *EditorAbout::_populate_list(const String &p_name, const List<St Ref<StyleBoxEmpty> empty_stylebox = memnew(StyleBoxEmpty); - for (int i = 0; i < p_sections.size(); i++) { + int i = 0; + for (List<String>::ConstIterator itr = p_sections.begin(); itr != p_sections.end(); ++itr, ++i) { bool single_column = p_single_column_flags & (1 << i); const char *const *names_ptr = p_src[i]; if (*names_ptr) { Label *lbl = memnew(Label); lbl->set_theme_type_variation("HeaderSmall"); - lbl->set_text(p_sections[i]); + lbl->set_text(*itr); vbc->add_child(lbl); ItemList *il = memnew(ItemList); |