diff options
| author | David Nikdel <david.nikdel@gmail.com> | 2024-06-10 08:34:25 -0400 |
|---|---|---|
| committer | David Nikdel <david.nikdel@gmail.com> | 2024-06-12 16:44:07 -0400 |
| commit | 5122a3e3b00e154c0148bb2709671e6c3a0b0432 (patch) | |
| tree | bb723beba73dea6b4aa37bfd687d94929a6b32a2 /editor/editor_file_system.cpp | |
| parent | 32eba1ee17555fbc4f4d348a568b6d9d391de9a5 (diff) | |
| download | redot-engine-5122a3e3b00e154c0148bb2709671e6c3a0b0432.tar.gz | |
editor: warn on UID duplicates
This commonly occurs when files are copied outside of the editor and don't get new UIDs.
Restricting this warning to first_scan since it's we want to exclude the case of files being moved after initial load which is harder to handle.
Addresses https://github.com/godotengine/godot-proposals/discussions/8949
Diffstat (limited to 'editor/editor_file_system.cpp')
| -rw-r--r-- | editor/editor_file_system.cpp | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/editor/editor_file_system.cpp b/editor/editor_file_system.cpp index 3adff84e40..cdaa001d9e 100644 --- a/editor/editor_file_system.cpp +++ b/editor/editor_file_system.cpp @@ -961,6 +961,14 @@ void EditorFileSystem::_scan_new_dir(EditorFileSystemDirectory *p_dir, Ref<DirAc if (fi->uid != ResourceUID::INVALID_ID) { if (ResourceUID::get_singleton()->has_id(fi->uid)) { + // Restrict UID dupe warning to first-scan since we know there are no file moves going on yet. + if (first_scan) { + // Warn if we detect files with duplicate UIDs. + const String other_path = ResourceUID::get_singleton()->get_id_path(fi->uid); + if (other_path != path) { + WARN_PRINT(vformat("UID duplicate detected between %s and %s.", path, other_path)); + } + } ResourceUID::get_singleton()->set_id(fi->uid, path); } else { ResourceUID::get_singleton()->add_id(fi->uid, path); |