summaryrefslogtreecommitdiffstats
path: root/editor/editor_file_system.cpp
diff options
context:
space:
mode:
authorRémi Verschelde <rverschelde@gmail.com>2024-06-21 13:54:35 +0200
committerRémi Verschelde <rverschelde@gmail.com>2024-06-21 13:54:35 +0200
commit74f9f12c71c0b1cd66481cdc8b3b3432b7c541a6 (patch)
treef8fa1051926f8201101b648bc0e5d1f841b3d7b3 /editor/editor_file_system.cpp
parent04a530f91fc83b41112007dbd2ce02e9528df682 (diff)
parentf1099ab943859f1e1510ffef5782b4d9c599bf80 (diff)
downloadredot-engine-74f9f12c71c0b1cd66481cdc8b3b3432b7c541a6.tar.gz
Merge pull request #92320 from Hilderin/fix-importing-assets-with-csv
Fix reimporting assets with csv in the project
Diffstat (limited to 'editor/editor_file_system.cpp')
-rw-r--r--editor/editor_file_system.cpp13
1 files changed, 11 insertions, 2 deletions
diff --git a/editor/editor_file_system.cpp b/editor/editor_file_system.cpp
index 4bca42bf8b..d84ccb0c03 100644
--- a/editor/editor_file_system.cpp
+++ b/editor/editor_file_system.cpp
@@ -2468,18 +2468,23 @@ void EditorFileSystem::reimport_files(const Vector<String> &p_files) {
int from = 0;
for (int i = 0; i < reimport_files.size(); i++) {
if (groups_to_reimport.has(reimport_files[i].path)) {
+ from = i + 1;
continue;
}
if (use_multiple_threads && reimport_files[i].threaded) {
- if (i + 1 == reimport_files.size() || reimport_files[i + 1].importer != reimport_files[from].importer) {
+ if (i + 1 == reimport_files.size() || reimport_files[i + 1].importer != reimport_files[from].importer || groups_to_reimport.has(reimport_files[i + 1].path)) {
if (from - i == 0) {
// Single file, do not use threads.
pr.step(reimport_files[i].path.get_file(), i);
_reimport_file(reimport_files[i].path);
} else {
Ref<ResourceImporter> importer = ResourceFormatImporter::get_singleton()->get_importer_by_name(reimport_files[from].importer);
- ERR_CONTINUE(!importer.is_valid());
+ if (importer.is_null()) {
+ ERR_PRINT(vformat("Invalid importer for \"%s\".", reimport_files[from].importer));
+ from = i + 1;
+ continue;
+ }
importer->import_threaded_begin();
@@ -2509,6 +2514,10 @@ void EditorFileSystem::reimport_files(const Vector<String> &p_files) {
} else {
pr.step(reimport_files[i].path.get_file(), i);
_reimport_file(reimport_files[i].path);
+
+ // We need to increment the counter, maybe the next file is multithreaded
+ // and doesn't have the same importer.
+ from = i + 1;
}
}