diff options
| author | Yuri Sizov <yuris@humnom.net> | 2023-12-04 13:18:48 +0100 |
|---|---|---|
| committer | Yuri Sizov <yuris@humnom.net> | 2023-12-04 13:18:48 +0100 |
| commit | 01888ae7ab2d8989b6e25cb2edbe7b3d27cf4e4e (patch) | |
| tree | 4e1bfbf8a8a6eb05279582dd5fe527a427f3cbeb /editor/plugins/path_3d_editor_plugin.cpp | |
| parent | d76c1d0e516fedc535a2e394ab780cac79203477 (diff) | |
| download | redot-engine-01888ae7ab2d8989b6e25cb2edbe7b3d27cf4e4e.tar.gz | |
Fix theme application in various editor dialogs
99% of the time we shouldn't rely on the signal, we
should use the notification instead. I left some comments
in places where I couldn't quickly improve the code.
Diffstat (limited to 'editor/plugins/path_3d_editor_plugin.cpp')
| -rw-r--r-- | editor/plugins/path_3d_editor_plugin.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/editor/plugins/path_3d_editor_plugin.cpp b/editor/plugins/path_3d_editor_plugin.cpp index 9d66e606b0..42c080fdf2 100644 --- a/editor/plugins/path_3d_editor_plugin.cpp +++ b/editor/plugins/path_3d_editor_plugin.cpp @@ -713,6 +713,9 @@ void Path3DEditorPlugin::_notification(int p_what) { } break; case NOTIFICATION_READY: { + // FIXME: This can trigger theme updates when the nodes that we want to update are not yet available. + // The toolbar should be extracted to a dedicated control and theme updates should be handled through + // the notification. Node3DEditor::get_singleton()->connect("theme_changed", callable_mp(this, &Path3DEditorPlugin::_update_theme)); } break; } |