diff options
author | A Thousand Ships <96648715+AThousandShips@users.noreply.github.com> | 2023-09-09 17:24:40 +0200 |
---|---|---|
committer | A Thousand Ships <96648715+AThousandShips@users.noreply.github.com> | 2023-09-15 20:15:39 +0200 |
commit | 75ee58fd0476360c67375cf403f06644a0aa117e (patch) | |
tree | dbfda27d4bcd56ed9dc6362c2e51521059e98788 /editor/plugins/tiles/tile_data_editors.cpp | |
parent | 5f1e56ff26be4070496aa51095b9ac2f2b4f4ed8 (diff) | |
download | redot-engine-75ee58fd0476360c67375cf403f06644a0aa117e.tar.gz |
[Editor] Replace `ERR_FAIL_COND` with `ERR_FAIL_NULL` where applicable
Diffstat (limited to 'editor/plugins/tiles/tile_data_editors.cpp')
-rw-r--r-- | editor/plugins/tiles/tile_data_editors.cpp | 44 |
1 files changed, 22 insertions, 22 deletions
diff --git a/editor/plugins/tiles/tile_data_editors.cpp b/editor/plugins/tiles/tile_data_editors.cpp index a63c2f5742..19dd2d51c0 100644 --- a/editor/plugins/tiles/tile_data_editors.cpp +++ b/editor/plugins/tiles/tile_data_editors.cpp @@ -948,19 +948,19 @@ GenericTilePolygonEditor::GenericTilePolygonEditor() { } void TileDataDefaultEditor::_property_value_changed(StringName p_property, Variant p_value, StringName p_field) { - ERR_FAIL_COND(!dummy_object); + ERR_FAIL_NULL(dummy_object); dummy_object->set(p_property, p_value); emit_signal(SNAME("needs_redraw")); } Variant TileDataDefaultEditor::_get_painted_value() { - ERR_FAIL_COND_V(!dummy_object, Variant()); + ERR_FAIL_NULL_V(dummy_object, Variant()); return dummy_object->get(property); } void TileDataDefaultEditor::_set_painted_value(TileSetAtlasSource *p_tile_set_atlas_source, Vector2 p_coords, int p_alternative_tile) { TileData *tile_data = p_tile_set_atlas_source->get_tile_data(p_coords, p_alternative_tile); - ERR_FAIL_COND(!tile_data); + ERR_FAIL_NULL(tile_data); Variant value = tile_data->get(property); dummy_object->set(property, value); if (property_editor) { @@ -970,13 +970,13 @@ void TileDataDefaultEditor::_set_painted_value(TileSetAtlasSource *p_tile_set_at void TileDataDefaultEditor::_set_value(TileSetAtlasSource *p_tile_set_atlas_source, Vector2 p_coords, int p_alternative_tile, Variant p_value) { TileData *tile_data = p_tile_set_atlas_source->get_tile_data(p_coords, p_alternative_tile); - ERR_FAIL_COND(!tile_data); + ERR_FAIL_NULL(tile_data); tile_data->set(property, p_value); } Variant TileDataDefaultEditor::_get_value(TileSetAtlasSource *p_tile_set_atlas_source, Vector2 p_coords, int p_alternative_tile) { TileData *tile_data = p_tile_set_atlas_source->get_tile_data(p_coords, p_alternative_tile); - ERR_FAIL_COND_V(!tile_data, Variant()); + ERR_FAIL_NULL_V(tile_data, Variant()); return tile_data->get(property); } @@ -1186,7 +1186,7 @@ void TileDataDefaultEditor::forward_painting_alternatives_gui_input(TileAtlasVie void TileDataDefaultEditor::draw_over_tile(CanvasItem *p_canvas_item, Transform2D p_transform, TileMapCell p_cell, bool p_selected) { TileData *tile_data = _get_tile_data(p_cell); - ERR_FAIL_COND(!tile_data); + ERR_FAIL_NULL(tile_data); bool valid; Variant value = tile_data->get(property, &valid); @@ -1315,7 +1315,7 @@ TileDataDefaultEditor::~TileDataDefaultEditor() { void TileDataTextureOriginEditor::draw_over_tile(CanvasItem *p_canvas_item, Transform2D p_transform, TileMapCell p_cell, bool p_selected) { TileData *tile_data = _get_tile_data(p_cell); - ERR_FAIL_COND(!tile_data); + ERR_FAIL_NULL(tile_data); Vector2i tile_set_tile_size = tile_set->get_tile_size(); Color color = Color(1.0, 1.0, 1.0); @@ -1349,7 +1349,7 @@ void TileDataTextureOriginEditor::draw_over_tile(CanvasItem *p_canvas_item, Tran void TileDataPositionEditor::draw_over_tile(CanvasItem *p_canvas_item, Transform2D p_transform, TileMapCell p_cell, bool p_selected) { TileData *tile_data = _get_tile_data(p_cell); - ERR_FAIL_COND(!tile_data); + ERR_FAIL_NULL(tile_data); bool valid; Variant value = tile_data->get(property, &valid); @@ -1370,7 +1370,7 @@ void TileDataPositionEditor::draw_over_tile(CanvasItem *p_canvas_item, Transform void TileDataYSortEditor::draw_over_tile(CanvasItem *p_canvas_item, Transform2D p_transform, TileMapCell p_cell, bool p_selected) { TileData *tile_data = _get_tile_data(p_cell); - ERR_FAIL_COND(!tile_data); + ERR_FAIL_NULL(tile_data); Color color = Color(1.0, 1.0, 1.0); if (p_selected) { @@ -1397,7 +1397,7 @@ void TileDataYSortEditor::draw_over_tile(CanvasItem *p_canvas_item, Transform2D void TileDataOcclusionShapeEditor::draw_over_tile(CanvasItem *p_canvas_item, Transform2D p_transform, TileMapCell p_cell, bool p_selected) { TileData *tile_data = _get_tile_data(p_cell); - ERR_FAIL_COND(!tile_data); + ERR_FAIL_NULL(tile_data); Color grid_color = EDITOR_GET("editors/tiles_editor/grid_color"); Color selection_color = Color().from_hsv(Math::fposmod(grid_color.get_h() + 0.5, 1.0), grid_color.get_s(), grid_color.get_v(), 1.0); @@ -1429,7 +1429,7 @@ Variant TileDataOcclusionShapeEditor::_get_painted_value() { void TileDataOcclusionShapeEditor::_set_painted_value(TileSetAtlasSource *p_tile_set_atlas_source, Vector2 p_coords, int p_alternative_tile) { TileData *tile_data = p_tile_set_atlas_source->get_tile_data(p_coords, p_alternative_tile); - ERR_FAIL_COND(!tile_data); + ERR_FAIL_NULL(tile_data); Ref<OccluderPolygon2D> occluder_polygon = tile_data->get_occluder(occlusion_layer); polygon_editor->clear_polygons(); @@ -1441,7 +1441,7 @@ void TileDataOcclusionShapeEditor::_set_painted_value(TileSetAtlasSource *p_tile void TileDataOcclusionShapeEditor::_set_value(TileSetAtlasSource *p_tile_set_atlas_source, Vector2 p_coords, int p_alternative_tile, Variant p_value) { TileData *tile_data = p_tile_set_atlas_source->get_tile_data(p_coords, p_alternative_tile); - ERR_FAIL_COND(!tile_data); + ERR_FAIL_NULL(tile_data); Ref<OccluderPolygon2D> occluder_polygon = p_value; tile_data->set_occluder(occlusion_layer, occluder_polygon); @@ -1450,7 +1450,7 @@ void TileDataOcclusionShapeEditor::_set_value(TileSetAtlasSource *p_tile_set_atl Variant TileDataOcclusionShapeEditor::_get_value(TileSetAtlasSource *p_tile_set_atlas_source, Vector2 p_coords, int p_alternative_tile) { TileData *tile_data = p_tile_set_atlas_source->get_tile_data(p_coords, p_alternative_tile); - ERR_FAIL_COND_V(!tile_data, Variant()); + ERR_FAIL_NULL_V(tile_data, Variant()); return tile_data->get_occluder(occlusion_layer); } @@ -1571,7 +1571,7 @@ Variant TileDataCollisionEditor::_get_painted_value() { void TileDataCollisionEditor::_set_painted_value(TileSetAtlasSource *p_tile_set_atlas_source, Vector2 p_coords, int p_alternative_tile) { TileData *tile_data = p_tile_set_atlas_source->get_tile_data(p_coords, p_alternative_tile); - ERR_FAIL_COND(!tile_data); + ERR_FAIL_NULL(tile_data); polygon_editor->clear_polygons(); for (int i = 0; i < tile_data->get_collision_polygons_count(physics_layer); i++) { @@ -1597,7 +1597,7 @@ void TileDataCollisionEditor::_set_painted_value(TileSetAtlasSource *p_tile_set_ void TileDataCollisionEditor::_set_value(TileSetAtlasSource *p_tile_set_atlas_source, Vector2 p_coords, int p_alternative_tile, Variant p_value) { TileData *tile_data = p_tile_set_atlas_source->get_tile_data(p_coords, p_alternative_tile); - ERR_FAIL_COND(!tile_data); + ERR_FAIL_NULL(tile_data); Dictionary dict = p_value; tile_data->set_constant_linear_velocity(physics_layer, dict["linear_velocity"]); @@ -1616,7 +1616,7 @@ void TileDataCollisionEditor::_set_value(TileSetAtlasSource *p_tile_set_atlas_so Variant TileDataCollisionEditor::_get_value(TileSetAtlasSource *p_tile_set_atlas_source, Vector2 p_coords, int p_alternative_tile) { TileData *tile_data = p_tile_set_atlas_source->get_tile_data(p_coords, p_alternative_tile); - ERR_FAIL_COND_V(!tile_data, Variant()); + ERR_FAIL_NULL_V(tile_data, Variant()); Dictionary dict; dict["linear_velocity"] = tile_data->get_constant_linear_velocity(physics_layer); @@ -1717,7 +1717,7 @@ TileDataCollisionEditor::~TileDataCollisionEditor() { void TileDataCollisionEditor::draw_over_tile(CanvasItem *p_canvas_item, Transform2D p_transform, TileMapCell p_cell, bool p_selected) { TileData *tile_data = _get_tile_data(p_cell); - ERR_FAIL_COND(!tile_data); + ERR_FAIL_NULL(tile_data); // Draw all shapes. Vector<Color> color; @@ -2767,7 +2767,7 @@ void TileDataTerrainsEditor::forward_painting_alternatives_gui_input(TileAtlasVi void TileDataTerrainsEditor::draw_over_tile(CanvasItem *p_canvas_item, Transform2D p_transform, TileMapCell p_cell, bool p_selected) { TileData *tile_data = _get_tile_data(p_cell); - ERR_FAIL_COND(!tile_data); + ERR_FAIL_NULL(tile_data); tile_set->draw_terrains(p_canvas_item, p_transform, tile_data); } @@ -2835,7 +2835,7 @@ Variant TileDataNavigationEditor::_get_painted_value() { void TileDataNavigationEditor::_set_painted_value(TileSetAtlasSource *p_tile_set_atlas_source, Vector2 p_coords, int p_alternative_tile) { TileData *tile_data = p_tile_set_atlas_source->get_tile_data(p_coords, p_alternative_tile); - ERR_FAIL_COND(!tile_data); + ERR_FAIL_NULL(tile_data); Ref<NavigationPolygon> nav_polygon = tile_data->get_navigation_polygon(navigation_layer); polygon_editor->clear_polygons(); @@ -2849,7 +2849,7 @@ void TileDataNavigationEditor::_set_painted_value(TileSetAtlasSource *p_tile_set void TileDataNavigationEditor::_set_value(TileSetAtlasSource *p_tile_set_atlas_source, Vector2 p_coords, int p_alternative_tile, Variant p_value) { TileData *tile_data = p_tile_set_atlas_source->get_tile_data(p_coords, p_alternative_tile); - ERR_FAIL_COND(!tile_data); + ERR_FAIL_NULL(tile_data); Ref<NavigationPolygon> nav_polygon = p_value; tile_data->set_navigation_polygon(navigation_layer, nav_polygon); @@ -2858,7 +2858,7 @@ void TileDataNavigationEditor::_set_value(TileSetAtlasSource *p_tile_set_atlas_s Variant TileDataNavigationEditor::_get_value(TileSetAtlasSource *p_tile_set_atlas_source, Vector2 p_coords, int p_alternative_tile) { TileData *tile_data = p_tile_set_atlas_source->get_tile_data(p_coords, p_alternative_tile); - ERR_FAIL_COND_V(!tile_data, Variant()); + ERR_FAIL_NULL_V(tile_data, Variant()); return tile_data->get_navigation_polygon(navigation_layer); } @@ -2893,7 +2893,7 @@ TileDataNavigationEditor::TileDataNavigationEditor() { void TileDataNavigationEditor::draw_over_tile(CanvasItem *p_canvas_item, Transform2D p_transform, TileMapCell p_cell, bool p_selected) { TileData *tile_data = _get_tile_data(p_cell); - ERR_FAIL_COND(!tile_data); + ERR_FAIL_NULL(tile_data); // Draw all shapes. RenderingServer::get_singleton()->canvas_item_add_set_transform(p_canvas_item->get_canvas_item(), p_transform); |