diff options
| author | Rémi Verschelde <rverschelde@gmail.com> | 2023-10-20 15:12:11 +0200 |
|---|---|---|
| committer | Rémi Verschelde <rverschelde@gmail.com> | 2023-10-20 15:12:11 +0200 |
| commit | 68a183a2d91709537fe5cab3ed989f97a590845c (patch) | |
| tree | feb3978a5c4444a01bc5b3d5f72b8eda2c140cf6 /editor/plugins/visual_shader_editor_plugin.cpp | |
| parent | 55fc347efd50d297de3b92a5bfc141e52e57c90f (diff) | |
| parent | 215e036600809fd588ec67b8d39efe12ae1ff4c5 (diff) | |
| download | redot-engine-68a183a2d91709537fe5cab3ed989f97a590845c.tar.gz | |
Merge pull request #83626 from YuriSizov/control-less-is-more-as-in-less-excessive-notifications-is-more-performance
Add bulk change guards to successive theme overrides in Editor and GUI
Diffstat (limited to 'editor/plugins/visual_shader_editor_plugin.cpp')
| -rw-r--r-- | editor/plugins/visual_shader_editor_plugin.cpp | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/editor/plugins/visual_shader_editor_plugin.cpp b/editor/plugins/visual_shader_editor_plugin.cpp index da3bbb84bf..f18585e9df 100644 --- a/editor/plugins/visual_shader_editor_plugin.cpp +++ b/editor/plugins/visual_shader_editor_plugin.cpp @@ -1095,9 +1095,12 @@ void VisualShaderGraphPlugin::add_node(VisualShader::Type p_type, int p_id, bool } } + expression_box->begin_bulk_theme_override(); expression_box->add_theme_font_override("font", editor->get_theme_font(SNAME("expression"), EditorStringName(EditorFonts))); expression_box->add_theme_font_size_override("font_size", editor->get_theme_font_size(SNAME("expression_size"), EditorStringName(EditorFonts))); expression_box->add_theme_color_override("font_color", text_color); + expression_box->end_bulk_theme_override(); + expression_syntax_highlighter->set_number_color(number_color); expression_syntax_highlighter->set_symbol_color(symbol_color); expression_syntax_highlighter->set_function_color(function_color); @@ -4197,9 +4200,12 @@ void VisualShaderEditor::_notification(int p_what) { } } + preview_text->begin_bulk_theme_override(); preview_text->add_theme_font_override("font", get_theme_font(SNAME("expression"), EditorStringName(EditorFonts))); preview_text->add_theme_font_size_override("font_size", get_theme_font_size(SNAME("expression_size"), EditorStringName(EditorFonts))); preview_text->add_theme_color_override("font_color", text_color); + preview_text->end_bulk_theme_override(); + syntax_highlighter->set_number_color(number_color); syntax_highlighter->set_symbol_color(symbol_color); syntax_highlighter->set_function_color(function_color); @@ -4213,9 +4219,11 @@ void VisualShaderEditor::_notification(int p_what) { preview_text->add_comment_delimiter("//", "", true); error_panel->add_theme_style_override("panel", get_theme_stylebox(SNAME("panel"), SNAME("Panel"))); + error_label->begin_bulk_theme_override(); error_label->add_theme_font_override("font", get_theme_font(SNAME("status_source"), EditorStringName(EditorFonts))); error_label->add_theme_font_size_override("font_size", get_theme_font_size(SNAME("status_source_size"), EditorStringName(EditorFonts))); error_label->add_theme_color_override("font_color", error_color); + error_label->end_bulk_theme_override(); } tools->set_icon(get_editor_theme_icon(SNAME("Tools"))); |