diff options
author | Rémi Verschelde <remi@verschelde.fr> | 2023-02-03 16:13:06 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-02-03 16:13:06 +0100 |
commit | 604493eb6ee3def65aca089c1d4bc71ea03ca19a (patch) | |
tree | 910adcfd1435a0297e6c5c7b05b2b538e8cc8e0d /modules/gdscript/gdscript.cpp | |
parent | eb91e909a7e2a4d905b1511de9cb53d949df82fc (diff) | |
parent | e9a3e49086d466e4beb3d8458149b58f5f6115bd (diff) | |
download | redot-engine-604493eb6ee3def65aca089c1d4bc71ea03ca19a.tar.gz |
Merge pull request #65910 from KoBeWi/gdsus
Cleanup function state connections when destroying instance
Diffstat (limited to 'modules/gdscript/gdscript.cpp')
-rw-r--r-- | modules/gdscript/gdscript.cpp | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/modules/gdscript/gdscript.cpp b/modules/gdscript/gdscript.cpp index 8324cb0fe0..a876229276 100644 --- a/modules/gdscript/gdscript.cpp +++ b/modules/gdscript/gdscript.cpp @@ -1496,7 +1496,12 @@ GDScript::~GDScript() { // Order matters since clearing the stack may already cause // the GDScriptFunctionState to be destroyed and thus removed from the list. pending_func_states.remove(E); - E->self()->_clear_stack(); + GDScriptFunctionState *state = E->self(); + ObjectID state_id = state->get_instance_id(); + state->_clear_connections(); + if (ObjectDB::get_instance(state_id)) { + state->_clear_stack(); + } } } @@ -1920,7 +1925,12 @@ GDScriptInstance::~GDScriptInstance() { // Order matters since clearing the stack may already cause // the GDSCriptFunctionState to be destroyed and thus removed from the list. pending_func_states.remove(E); - E->self()->_clear_stack(); + GDScriptFunctionState *state = E->self(); + ObjectID state_id = state->get_instance_id(); + state->_clear_connections(); + if (ObjectDB::get_instance(state_id)) { + state->_clear_stack(); + } } if (script.is_valid() && owner) { |