diff options
| author | clayjohn <claynjohn@gmail.com> | 2022-10-13 12:42:11 -0700 |
|---|---|---|
| committer | clayjohn <claynjohn@gmail.com> | 2022-10-14 10:43:42 -0700 |
| commit | 0a51bb4ca54fa9fd15b40dac28476eae6ff0c816 (patch) | |
| tree | 765ab472e450cd7308f16082cf442cad58fb8e8c /modules/gdscript/gdscript_analyzer.cpp | |
| parent | 39534a7aecc4ca4215af67244b23dda09ea339f8 (diff) | |
| download | redot-engine-0a51bb4ca54fa9fd15b40dac28476eae6ff0c816.tar.gz | |
Add STATIC_CALLED_ON_INSTANCE warning to highlight
when static functions are called directly from objects
Diffstat (limited to 'modules/gdscript/gdscript_analyzer.cpp')
| -rw-r--r-- | modules/gdscript/gdscript_analyzer.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/modules/gdscript/gdscript_analyzer.cpp b/modules/gdscript/gdscript_analyzer.cpp index b3ca8ff00a..6fbdec863f 100644 --- a/modules/gdscript/gdscript_analyzer.cpp +++ b/modules/gdscript/gdscript_analyzer.cpp @@ -2552,6 +2552,10 @@ void GDScriptAnalyzer::reduce_call(GDScriptParser::CallNode *p_call, bool p_is_a if (p_is_root && return_type.kind != GDScriptParser::DataType::UNRESOLVED && return_type.builtin_type != Variant::NIL) { parser->push_warning(p_call, GDScriptWarning::RETURN_VALUE_DISCARDED, p_call->function_name); } + + if (is_static && !base_type.is_meta_type && !(callee_type != GDScriptParser::Node::SUBSCRIPT && parser->current_function != nullptr && parser->current_function->is_static)) { + parser->push_warning(p_call, GDScriptWarning::STATIC_CALLED_ON_INSTANCE, p_call->function_name, base_type.to_string()); + } #endif // DEBUG_ENABLED call_type = return_type; |