diff options
| author | mandryskowski <nedesf@gmail.com> | 2023-07-18 19:18:19 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-07-18 19:18:19 +0200 |
| commit | 33e46aac13f35511ddb0a58f6441e3d8b7fe1f35 (patch) | |
| tree | 235f15bc7fa8567c1c8a76a21df9bbc30c758d5b /modules/gdscript/gdscript_editor.cpp | |
| parent | e8aa8c17d289097e24734a28f3bf9e806fd8a944 (diff) | |
| download | redot-engine-33e46aac13f35511ddb0a58f6441e3d8b7fe1f35.tar.gz | |
Revert the change of the limit for interpolation of R0 with respect to metallic and SSR
Commit 2c000cb72fc04fd76c5d3b6bc53955f83bf50c71 changed the interpolation limits from (0.04, 1.0) to (0.04, 0.37). This is incorrect, as we want to have an F0 of 0.04 for dielectrics (materials with metalness of 0.0) and an F0 of 1.0 for metals.
The Schlick approximation uses an F0 of 0.04 for all dielectrics and it's good enough.
Having it lower than 1.0 leads to an incorrect application of the Fresnel effect for metals and leads to bugs like #79549
Diffstat (limited to 'modules/gdscript/gdscript_editor.cpp')
0 files changed, 0 insertions, 0 deletions