diff options
| author | George Marques <george@gmarqu.es> | 2023-02-07 17:09:40 -0300 |
|---|---|---|
| committer | George Marques <george@gmarqu.es> | 2023-02-07 17:09:40 -0300 |
| commit | 34f0a2ca46bda37c49caf0a4e2feb25e1ce9ad4f (patch) | |
| tree | a9d65de9167e4a5719f2421b312062bbe0d3ee27 /modules/gdscript/gdscript_function.h | |
| parent | a05670c617abc1df93ebac5afacf3e6c48008a99 (diff) | |
| download | redot-engine-34f0a2ca46bda37c49caf0a4e2feb25e1ce9ad4f.tar.gz | |
GDScript: Add limit to call depth
The hard limit is set at 2048 depth which seems sensible between
legitimate recursive calls while still avoiding a crash because of a
stack overflow in most of the cases.
Note that it is still possible to reach the stack limit and get an
overflow before reaching a call depth. This is intended as a half-way
measure to stop crashing in most cases, since there's no reliable nor
portable way to check the amount of stack memory left.
Diffstat (limited to 'modules/gdscript/gdscript_function.h')
| -rw-r--r-- | modules/gdscript/gdscript_function.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/modules/gdscript/gdscript_function.h b/modules/gdscript/gdscript_function.h index f45c1f9577..2624fb8dd9 100644 --- a/modules/gdscript/gdscript_function.h +++ b/modules/gdscript/gdscript_function.h @@ -544,6 +544,8 @@ private: #endif public: + static constexpr int MAX_CALL_DEPTH = 2048; // Limit to try to avoid crash because of a stack overflow. + struct CallState { GDScript *script = nullptr; GDScriptInstance *instance = nullptr; |