summaryrefslogtreecommitdiffstats
path: root/modules/gdscript/gdscript_parser.cpp
diff options
context:
space:
mode:
authorPreslavPetrov <preslavnpetrov@gmail.com>2024-05-04 18:41:01 +0100
committerPreslavPetrov <preslavnpetrov@gmail.com>2024-06-03 13:28:17 +0100
commit653a8b113a9677e534fa7061f39c7f56b3ed3663 (patch)
treeea858edeb57721114c02b9b29a75ba21aa981a02 /modules/gdscript/gdscript_parser.cpp
parent0d11108a01ca5017e055e498c579a271f3153ee1 (diff)
downloadredot-engine-653a8b113a9677e534fa7061f39c7f56b3ed3663.tar.gz
Register the export info correctly when a global class script is used as the variable type for Node
Diffstat (limited to 'modules/gdscript/gdscript_parser.cpp')
-rw-r--r--modules/gdscript/gdscript_parser.cpp36
1 files changed, 26 insertions, 10 deletions
diff --git a/modules/gdscript/gdscript_parser.cpp b/modules/gdscript/gdscript_parser.cpp
index 9a4c92f601..771ccf47b7 100644
--- a/modules/gdscript/gdscript_parser.cpp
+++ b/modules/gdscript/gdscript_parser.cpp
@@ -4315,39 +4315,55 @@ bool GDScriptParser::export_annotations(const AnnotationNode *p_annotation, Node
return false;
}
break;
- case GDScriptParser::DataType::CLASS:
+ case GDScriptParser::DataType::CLASS: {
+ StringName class_name;
+ if (export_type.class_type) {
+ class_name = export_type.class_type->get_global_name();
+ }
+ if (class_name == StringName()) {
+ push_error(R"(Script export type must be a global class.)", p_annotation);
+ return false;
+ }
if (ClassDB::is_parent_class(export_type.native_type, SNAME("Resource"))) {
variable->export_info.type = Variant::OBJECT;
variable->export_info.hint = PROPERTY_HINT_RESOURCE_TYPE;
- variable->export_info.hint_string = export_type.to_string();
+ variable->export_info.hint_string = class_name;
} else if (ClassDB::is_parent_class(export_type.native_type, SNAME("Node"))) {
variable->export_info.type = Variant::OBJECT;
variable->export_info.hint = PROPERTY_HINT_NODE_TYPE;
- variable->export_info.hint_string = export_type.to_string();
+ variable->export_info.hint_string = class_name;
} else {
push_error(R"(Export type can only be built-in, a resource, a node, or an enum.)", p_annotation);
return false;
}
+ } break;
- break;
case GDScriptParser::DataType::SCRIPT: {
StringName class_name;
- StringName native_base;
if (export_type.script_type.is_valid()) {
- class_name = export_type.script_type->get_language()->get_global_class_name(export_type.script_type->get_path());
- native_base = export_type.script_type->get_instance_base_type();
+ class_name = export_type.script_type->get_global_name();
}
if (class_name == StringName()) {
Ref<Script> script = ResourceLoader::load(export_type.script_path, SNAME("Script"));
if (script.is_valid()) {
- class_name = script->get_language()->get_global_class_name(export_type.script_path);
- native_base = script->get_instance_base_type();
+ class_name = script->get_global_name();
}
}
- if (class_name != StringName() && native_base != StringName() && ClassDB::is_parent_class(native_base, SNAME("Resource"))) {
+ if (class_name == StringName()) {
+ push_error(R"(Script export type must be a global class.)", p_annotation);
+ return false;
+ }
+ if (ClassDB::is_parent_class(export_type.native_type, SNAME("Resource"))) {
variable->export_info.type = Variant::OBJECT;
variable->export_info.hint = PROPERTY_HINT_RESOURCE_TYPE;
variable->export_info.hint_string = class_name;
+ } else if (ClassDB::is_parent_class(export_type.native_type, SNAME("Node"))) {
+ variable->export_info.type = Variant::OBJECT;
+ variable->export_info.hint = PROPERTY_HINT_NODE_TYPE;
+ variable->export_info.hint_string = class_name;
+ } else {
+ push_error(R"(Export type can only be built-in, a resource, a node, or an enum.)", p_annotation);
+ return false;
}
} break;
case GDScriptParser::DataType::ENUM: {