diff options
| author | Houkime <qahmnatorA_Tprotonmail.com> | 2020-01-02 14:02:29 +0000 |
|---|---|---|
| committer | Houkime <qahmnatorA_Tprotonmail.com> | 2020-01-15 00:29:59 +0000 |
| commit | e1a0ce5af94cdb77e689916e730a655ea0ec823c (patch) | |
| tree | 94fbabb7139d1da2d8f4ab9cdf5f3c48cc39bf45 /modules/gdscript/language_server/gdscript_language_server.cpp | |
| parent | 40f0649e5b02037cb4745c336170e1e5422467ed (diff) | |
| download | redot-engine-e1a0ce5af94cdb77e689916e730a655ea0ec823c.tar.gz | |
Prevent GDScript language server from listening to external hosts by default
* Add bind_ip property to WebSocketServer defaulting to "*" (listen to everyone)
* Set default for GDscript Language Server to listen only to localhost
Fixes potential security issue with GDScript language server being exposed to the
broad net by default.
Since it is the server which primary usage is to provide utility to the local
editor there is no need to expose it.
Diffstat (limited to 'modules/gdscript/language_server/gdscript_language_server.cpp')
| -rw-r--r-- | modules/gdscript/language_server/gdscript_language_server.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/modules/gdscript/language_server/gdscript_language_server.cpp b/modules/gdscript/language_server/gdscript_language_server.cpp index 19bb3ed1ee..7170c63058 100644 --- a/modules/gdscript/language_server/gdscript_language_server.cpp +++ b/modules/gdscript/language_server/gdscript_language_server.cpp @@ -84,7 +84,7 @@ void GDScriptLanguageServer::thread_main(void *p_userdata) { void GDScriptLanguageServer::start() { port = (int)_EDITOR_GET("network/language_server/remote_port"); use_thread = (bool)_EDITOR_GET("network/language_server/use_thread"); - if (protocol.start(port) == OK) { + if (protocol.start(port, IP_Address("127.0.0.1")) == OK) { EditorNode::get_log()->add_message("--- GDScript language server started ---", EditorLog::MSG_TYPE_EDITOR); if (use_thread) { ERR_FAIL_COND(thread != NULL); |