diff options
| author | Rémi Verschelde <rverschelde@gmail.com> | 2024-05-07 09:04:44 +0200 |
|---|---|---|
| committer | Rémi Verschelde <rverschelde@gmail.com> | 2024-05-07 09:04:44 +0200 |
| commit | e63252b4219680d109bfa41c24f483e97b37f40e (patch) | |
| tree | 8b8af6d7efcab9b2692d45dec65449fd83d2c8b9 /modules/gdscript/language_server/gdscript_workspace.cpp | |
| parent | 570220ba9b127325f1a5aa7bb17d5c6f76ccf62c (diff) | |
| parent | 955d5affa857ec1f358c56da8fb1ff4ab6590704 (diff) | |
| download | redot-engine-e63252b4219680d109bfa41c24f483e97b37f40e.tar.gz | |
Merge pull request #90705 from AThousandShips/foreach_list
Reduce and prevent unnecessary random-access to `List`
Diffstat (limited to 'modules/gdscript/language_server/gdscript_workspace.cpp')
| -rw-r--r-- | modules/gdscript/language_server/gdscript_workspace.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/modules/gdscript/language_server/gdscript_workspace.cpp b/modules/gdscript/language_server/gdscript_workspace.cpp index a63d32ef30..819611099e 100644 --- a/modules/gdscript/language_server/gdscript_workspace.cpp +++ b/modules/gdscript/language_server/gdscript_workspace.cpp @@ -223,7 +223,7 @@ void GDScriptWorkspace::reload_all_workspace_scripts() { HashMap<String, ExtendGDScriptParser *>::Iterator S = parse_results.find(path); String err_msg = "Failed parse script " + path; if (S) { - err_msg += "\n" + S->value->get_errors()[0].message; + err_msg += "\n" + S->value->get_errors().front()->get().message; } ERR_CONTINUE_MSG(err != OK, err_msg); } @@ -619,8 +619,8 @@ Node *GDScriptWorkspace::_get_owner_scene_node(String p_path) { _get_owners(EditorFileSystem::get_singleton()->get_filesystem(), p_path, owners); - for (int i = 0; i < owners.size(); i++) { - NodePath owner_path = owners[i]; + for (const String &owner : owners) { + NodePath owner_path = owner; Ref<Resource> owner_res = ResourceLoader::load(owner_path); if (Object::cast_to<PackedScene>(owner_res.ptr())) { Ref<PackedScene> owner_packed_scene = Ref<PackedScene>(Object::cast_to<PackedScene>(*owner_res)); |