diff options
| author | Fabio Alessandrelli <fabio.alessandrelli@gmail.com> | 2023-05-12 19:55:58 +0200 |
|---|---|---|
| committer | Fabio Alessandrelli <fabio.alessandrelli@gmail.com> | 2023-05-12 20:08:10 +0200 |
| commit | eeac6f8c7f070a9f4674bfa51ec35c57516311c0 (patch) | |
| tree | b060293d6c34c9b72dccbb1b76ec5a02a5cf452b /modules/websocket | |
| parent | 20ed51a9129f97bb8d001262155fb3ccfc1e3c89 (diff) | |
| download | redot-engine-eeac6f8c7f070a9f4674bfa51ec35c57516311c0.tar.gz | |
[TLS] Fix crashes trying to use TLS when not available.
If no StreamPeerTLS implementation is available, HTTPClient and
WebSocketPeer will now correctly refuse to connect using TLS returning
ERR_UNAVAILABLE.
Similarly, ENetConnection will refuse to setup DTLS when PacketPeerDTLS
is not available.
Diffstat (limited to 'modules/websocket')
| -rw-r--r-- | modules/websocket/wsl_peer.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/modules/websocket/wsl_peer.cpp b/modules/websocket/wsl_peer.cpp index 816d5276b9..109d5102c3 100644 --- a/modules/websocket/wsl_peer.cpp +++ b/modules/websocket/wsl_peer.cpp @@ -332,7 +332,7 @@ void WSLPeer::_do_client_handshake() { if (connection == tcp) { // Start SSL handshake tls = Ref<StreamPeerTLS>(StreamPeerTLS::create()); - ERR_FAIL_COND_MSG(tls.is_null(), "SSL is not available in this build."); + ERR_FAIL_COND(tls.is_null()); if (tls->connect_to_stream(tcp, requested_host, tls_options) != OK) { close(-1); return; // Error. @@ -501,6 +501,8 @@ Error WSLPeer::connect_to_url(const String &p_url, Ref<TLSOptions> p_options) { path = "/"; } + ERR_FAIL_COND_V_MSG(use_tls && !StreamPeerTLS::is_available(), ERR_UNAVAILABLE, "WSS is not available in this build."); + requested_url = p_url; requested_host = host; |