summaryrefslogtreecommitdiffstats
path: root/modules
diff options
context:
space:
mode:
authorRémi Verschelde <rverschelde@gmail.com>2023-06-19 13:34:56 +0200
committerRémi Verschelde <rverschelde@gmail.com>2023-06-19 13:34:56 +0200
commitc79183817df84faaa7a67a32c00c5a2bd46dc632 (patch)
treed7e6cf4b63b238b3b313a268c31540f8837d1d92 /modules
parentcdfaf8a10f10ea07c83be698244dd9ae1ba7863e (diff)
downloadredot-engine-c79183817df84faaa7a67a32c00c5a2bd46dc632.tar.gz
Revert "minimp3: Add a .cpp file to simplify building the single-header implementation"
This reverts commit 6fc09121378d78026f799a820ce689f2d30bb0c9.
Diffstat (limited to 'modules')
-rw-r--r--modules/minimp3/SCsub26
-rw-r--r--modules/minimp3/audio_stream_mp3.cpp5
2 files changed, 11 insertions, 20 deletions
diff --git a/modules/minimp3/SCsub b/modules/minimp3/SCsub
index 0f86ed5a88..20e3165f38 100644
--- a/modules/minimp3/SCsub
+++ b/modules/minimp3/SCsub
@@ -5,27 +5,13 @@ Import("env_modules")
env_minimp3 = env_modules.Clone()
-# Thirdparty source files
-
-thirdparty_obj = []
-
thirdparty_dir = "#thirdparty/minimp3/"
-thirdparty_sources = [thirdparty_dir + "minimp3_ex.cpp"]
-
-env_minimp3.Prepend(CPPPATH=[thirdparty_dir])
-
-env_thirdparty = env_minimp3.Clone()
-env_thirdparty.disable_warnings()
-env_thirdparty.add_source_files(thirdparty_obj, thirdparty_sources)
-env.modules_sources += thirdparty_obj
+# Treat minimp3 headers as system headers to avoid raising warnings. Not supported on MSVC.
+if not env.msvc:
+ env_minimp3.Append(CPPFLAGS=["-isystem", Dir(thirdparty_dir).path])
+else:
+ env_minimp3.Prepend(CPPPATH=[thirdparty_dir])
# Godot source files
-
-module_obj = []
-
-env_minimp3.add_source_files(module_obj, "*.cpp")
-env.modules_sources += module_obj
-
-# Needed to force rebuilding the module files when the thirdparty library is updated.
-env.Depends(module_obj, thirdparty_obj)
+env_minimp3.add_source_files(env.modules_sources, "*.cpp")
diff --git a/modules/minimp3/audio_stream_mp3.cpp b/modules/minimp3/audio_stream_mp3.cpp
index c63ec3cad0..6af86a96dc 100644
--- a/modules/minimp3/audio_stream_mp3.cpp
+++ b/modules/minimp3/audio_stream_mp3.cpp
@@ -28,6 +28,11 @@
/* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
/**************************************************************************/
+#define MINIMP3_ONLY_MP3
+#define MINIMP3_FLOAT_OUTPUT
+#define MINIMP3_IMPLEMENTATION
+#define MINIMP3_NO_STDIO
+
#include "audio_stream_mp3.h"
#include "core/io/file_access.h"