diff options
author | Rémi Verschelde <remi@verschelde.fr> | 2024-09-17 12:39:29 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-09-17 12:39:29 +0200 |
commit | 6225d3982604829084c2c92a2ff87fce0ca6ed8b (patch) | |
tree | 900076c19513ab8e66f35dd4f11151cdb17e069e /platform/android/export/export_plugin.cpp | |
parent | d40fc50f086d14583c7cc979ed4e5363ac223717 (diff) | |
parent | 3a2804a7e770ea6f383355815282b77b90c43863 (diff) | |
download | redot-engine-6225d3982604829084c2c92a2ff87fce0ca6ed8b.tar.gz |
Merge pull request #97082 from akien-mga/4.3-cherrypicks
[4.3] Cherry-picks for the 4.3 branch (future 4.3.1) - 1st batch
Diffstat (limited to 'platform/android/export/export_plugin.cpp')
-rw-r--r-- | platform/android/export/export_plugin.cpp | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/platform/android/export/export_plugin.cpp b/platform/android/export/export_plugin.cpp index 5169b9417f..d5153fb6c0 100644 --- a/platform/android/export/export_plugin.cpp +++ b/platform/android/export/export_plugin.cpp @@ -290,7 +290,9 @@ void EditorExportPlatformAndroid::_check_for_changes_poll_thread(void *ud) { // Check for devices updates String adb = get_adb_path(); - if (ea->has_runnable_preset.is_set() && FileAccess::exists(adb)) { + // adb.exe was locking the editor_doc_cache file on startup. Adding a check for is_editor_ready provides just enough time + // to regenerate the doc cache. + if (ea->has_runnable_preset.is_set() && FileAccess::exists(adb) && EditorNode::get_singleton()->is_editor_ready()) { String devices; List<String> args; args.push_back("devices"); @@ -2272,6 +2274,11 @@ String EditorExportPlatformAndroid::get_apksigner_path(int p_target_sdk, bool p_ bool failed = false; String version_to_use; + String java_sdk_path = EDITOR_GET("export/android/java_sdk_path"); + if (!java_sdk_path.is_empty()) { + OS::get_singleton()->set_environment("JAVA_HOME", java_sdk_path); + } + List<String> args; args.push_back("--version"); String output; |