summaryrefslogtreecommitdiffstats
path: root/platform/android
diff options
context:
space:
mode:
authorFredia Huya-Kouadio <fhuyakou@gmail.com>2024-04-19 07:14:05 -0700
committerFredia Huya-Kouadio <fhuyakou@gmail.com>2024-04-19 07:56:02 -0700
commit764de7fe3195c28be1d9b8abc26ffdf394e87cb3 (patch)
treeb31221f380e958f3bb1d92b38bae14423553cfdc /platform/android
parentede88cf59d20da54042f16df3fe6ab1aca760d64 (diff)
downloadredot-engine-764de7fe3195c28be1d9b8abc26ffdf394e87cb3.tar.gz
Collapse the gdextension arguments into the `GDExtensionData` struct
This is used to reduce the number of arguments to `OS::open_dynamic_library(...)`.
Diffstat (limited to 'platform/android')
-rw-r--r--platform/android/os_android.cpp8
-rw-r--r--platform/android/os_android.h2
2 files changed, 5 insertions, 5 deletions
diff --git a/platform/android/os_android.cpp b/platform/android/os_android.cpp
index 93a17aea7b..1583e655d8 100644
--- a/platform/android/os_android.cpp
+++ b/platform/android/os_android.cpp
@@ -194,7 +194,7 @@ bool OS_Android::copy_dynamic_library(const String &p_library_path, const String
return copy_exists;
}
-Error OS_Android::open_dynamic_library(const String &p_path, void *&p_library_handle, bool p_also_set_library_path, String *r_resolved_path, bool p_generate_temp_files, PackedStringArray *p_library_dependencies) {
+Error OS_Android::open_dynamic_library(const String &p_path, void *&p_library_handle, GDExtensionData *p_data) {
String path = p_path;
bool so_file_exists = true;
if (!FileAccess::exists(path)) {
@@ -208,7 +208,7 @@ Error OS_Android::open_dynamic_library(const String &p_path, void *&p_library_ha
// Try to copy to the internal directory for access.
const String dynamic_library_path = get_dynamic_libraries_path();
- if (p_library_dependencies != nullptr && !p_library_dependencies->is_empty()) {
+ if (p_data != nullptr && p_data->library_dependencies != nullptr && !p_data->library_dependencies->is_empty()) {
// Copy the library dependencies
print_verbose("Copying library dependencies..");
for (const String &library_dependency_path : *p_data->library_dependencies) {
@@ -239,8 +239,8 @@ Error OS_Android::open_dynamic_library(const String &p_path, void *&p_library_ha
ERR_FAIL_NULL_V_MSG(p_library_handle, ERR_CANT_OPEN, vformat("Can't open dynamic library: %s. Error: %s.", p_path, dlerror()));
- if (r_resolved_path != nullptr) {
- *r_resolved_path = path;
+ if (p_data != nullptr && p_data->r_resolved_path != nullptr) {
+ *p_data->r_resolved_path = path;
}
return OK;
diff --git a/platform/android/os_android.h b/platform/android/os_android.h
index b6be5d8ba4..7bdbeef77a 100644
--- a/platform/android/os_android.h
+++ b/platform/android/os_android.h
@@ -113,7 +113,7 @@ public:
virtual void alert(const String &p_alert, const String &p_title) override;
- virtual Error open_dynamic_library(const String &p_path, void *&p_library_handle, bool p_also_set_library_path = false, String *r_resolved_path = nullptr, bool p_generate_temp_files = false, PackedStringArray *p_library_dependencies = nullptr) override;
+ virtual Error open_dynamic_library(const String &p_path, void *&p_library_handle, GDExtensionData *p_data = nullptr) override;
virtual String get_name() const override;
virtual String get_distribution_name() const override;