diff options
| author | Fredia Huya-Kouadio <fhuya@fb.com> | 2022-08-14 19:26:22 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-08-14 19:26:22 -0700 |
| commit | 5a8d786ef9dcfd5b206ec3eeb5e369930e773acc (patch) | |
| tree | 2274723d72b9dabc2107a6cc87b86b22288c1d13 /platform/macos/export/export_plugin.cpp | |
| parent | 128d68796d9f412a5b05cca8714f217341cfa376 (diff) | |
| parent | 45c73775561808ccb2eb4a59927d9c59965e3d20 (diff) | |
| download | redot-engine-5a8d786ef9dcfd5b206ec3eeb5e369930e773acc.tar.gz | |
Merge pull request #63122 from m4gr3d/split_can_export_main
Refactor the export checking logic to improve separation of concerns
Diffstat (limited to 'platform/macos/export/export_plugin.cpp')
| -rw-r--r-- | platform/macos/export/export_plugin.cpp | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/platform/macos/export/export_plugin.cpp b/platform/macos/export/export_plugin.cpp index bcc2636c07..edce9c0380 100644 --- a/platform/macos/export/export_plugin.cpp +++ b/platform/macos/export/export_plugin.cpp @@ -1550,7 +1550,7 @@ void EditorExportPlatformMacOS::_zip_folder_recursive(zipFile &p_zip, const Stri da->list_dir_end(); } -bool EditorExportPlatformMacOS::can_export(const Ref<EditorExportPreset> &p_preset, String &r_error, bool &r_missing_templates) const { +bool EditorExportPlatformMacOS::has_valid_export_configuration(const Ref<EditorExportPreset> &p_preset, String &r_error, bool &r_missing_templates) const { String err; bool valid = false; @@ -1580,6 +1580,17 @@ bool EditorExportPlatformMacOS::can_export(const Ref<EditorExportPreset> &p_pres valid = dvalid || rvalid; r_missing_templates = !valid; + if (!err.is_empty()) { + r_error = err; + } + + return valid; +} + +bool EditorExportPlatformMacOS::has_valid_project_configuration(const Ref<EditorExportPreset> &p_preset, String &r_error) const { + String err; + bool valid = true; + String identifier = p_preset->get("application/bundle_identifier"); String pn_err; if (!is_package_name_valid(identifier, &pn_err)) { |
