summaryrefslogtreecommitdiffstats
path: root/scene/3d/light.cpp
diff options
context:
space:
mode:
authorHugo Locurcio <hugo.locurcio@hugo.pro>2019-07-07 16:22:09 +0200
committerHugo Locurcio <hugo.locurcio@hugo.pro>2019-07-09 00:20:46 +0200
commitcdd41d446fde4d4ef5be74986110724427ad6f2f (patch)
tree21194f10ac7891a7eae924d6e78a3119e891b348 /scene/3d/light.cpp
parent1fa26b969c296ca62462debf01c22e2cc0aa059e (diff)
downloadredot-engine-cdd41d446fde4d4ef5be74986110724427ad6f2f.tar.gz
Add a configuration warning when using ultrawide SpotLight with shadows
This partially addresses #12028.
Diffstat (limited to 'scene/3d/light.cpp')
-rw-r--r--scene/3d/light.cpp19
1 files changed, 19 insertions, 0 deletions
diff --git a/scene/3d/light.cpp b/scene/3d/light.cpp
index 2e64872616..4ef945ab8d 100644
--- a/scene/3d/light.cpp
+++ b/scene/3d/light.cpp
@@ -51,6 +51,7 @@ void Light::set_param(Param p_param, float p_value) {
if (p_param == PARAM_SPOT_ANGLE) {
_change_notify("spot_angle");
+ update_configuration_warning();
} else if (p_param == PARAM_RANGE) {
_change_notify("omni_range");
_change_notify("spot_range");
@@ -68,6 +69,10 @@ void Light::set_shadow(bool p_enable) {
shadow = p_enable;
VS::get_singleton()->light_set_shadow(light, p_enable);
+
+ if (type == VisualServer::LIGHT_SPOT) {
+ update_configuration_warning();
+ }
}
bool Light::has_shadow() const {
@@ -465,6 +470,20 @@ OmniLight::OmniLight() :
set_shadow_detail(SHADOW_DETAIL_HORIZONTAL);
}
+String SpotLight::get_configuration_warning() const {
+ String warning = Light::get_configuration_warning();
+
+ if (has_shadow() && get_param(PARAM_SPOT_ANGLE) >= 90.0) {
+ if (warning != String()) {
+ warning += "\n\n";
+ }
+
+ warning += TTR("A SpotLight with an angle wider than 90 degrees cannot cast shadows.");
+ }
+
+ return warning;
+}
+
void SpotLight::_bind_methods() {
ADD_GROUP("Spot", "spot_");