summaryrefslogtreecommitdiffstats
path: root/scene/gui
diff options
context:
space:
mode:
authorRémi Verschelde <rverschelde@gmail.com>2023-11-12 15:22:04 +0100
committerRémi Verschelde <rverschelde@gmail.com>2023-11-12 15:22:16 +0100
commit7d0c561e02d37a27884162128387064f4fb1b90b (patch)
tree646e90a6fe5189a9c248f43586d2c84f2876a71f /scene/gui
parent5abeb043d00c523b433cf3c9f6940142a3eeb368 (diff)
downloadredot-engine-7d0c561e02d37a27884162128387064f4fb1b90b.tar.gz
VideoPlayer: Fix reloading translation remapped stream
Fixes #43917.
Diffstat (limited to 'scene/gui')
-rw-r--r--scene/gui/video_stream_player.cpp10
1 files changed, 10 insertions, 0 deletions
diff --git a/scene/gui/video_stream_player.cpp b/scene/gui/video_stream_player.cpp
index ac09844128..41a210e180 100644
--- a/scene/gui/video_stream_player.cpp
+++ b/scene/gui/video_stream_player.cpp
@@ -237,6 +237,12 @@ bool VideoStreamPlayer::has_loop() const {
void VideoStreamPlayer::set_stream(const Ref<VideoStream> &p_stream) {
stop();
+ // Make sure to handle stream changes seamlessly, e.g. when done via
+ // translation remapping.
+ if (stream.is_valid()) {
+ stream->disconnect_changed(callable_mp(this, &VideoStreamPlayer::set_stream));
+ }
+
AudioServer::get_singleton()->lock();
mix_buffer.resize(AudioServer::get_singleton()->thread_get_mix_buffer_size());
stream = p_stream;
@@ -248,6 +254,10 @@ void VideoStreamPlayer::set_stream(const Ref<VideoStream> &p_stream) {
}
AudioServer::get_singleton()->unlock();
+ if (stream.is_valid()) {
+ stream->connect_changed(callable_mp(this, &VideoStreamPlayer::set_stream).bind(stream));
+ }
+
if (!playback.is_null()) {
playback->set_paused(paused);
texture = playback->get_texture();